Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor code style edits to user guide #2660

Merged
merged 7 commits into from
Jun 28, 2017
Merged

Minor code style edits to user guide #2660

merged 7 commits into from
Jun 28, 2017

Conversation

gaearon
Copy link
Contributor

@gaearon gaearon commented Jun 28, 2017

Trying to be more consistent and show diffs.

@gaearon gaearon added this to the 1.0.8 milestone Jun 28, 2017
@gaearon gaearon merged commit 0cebe04 into master Jun 28, 2017
@gaearon gaearon mentioned this pull request Jun 28, 2017

Then, add these scripts to your `package.json`:

```diff
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoa, this is freaking smart!!! 🦆

@gaearon gaearon mentioned this pull request Jun 28, 2017
zangrafx added a commit to absolvent/create-react-app that referenced this pull request Jun 29, 2017
* upstream/master: (55 commits)
  Fix minor typo (facebook#2679)
  Bootstrap with Yarn when available (facebook#2673)
  Add more info about apache client side routing (facebook#2666)
  Test Node 8 on Travis (facebook#2659)
  Add json and css to lint-staged in template README (facebook#2671)
  Add a note about fixed vulnerability in 1.0.8
  Publish
  Changelog for 1.0.8 (facebook#2664)
  Reformat source code with Prettier 1.5.2
  Update Prettier to v1 (facebook#2465)
  Update ISSUE_TEMPLATE.md
  Local testing docker links (facebook#2662)
  Better React Native Web support (facebook#2511)
  Bump dependencies (facebook#2658)
  Minor code style edits to user guide (facebook#2660)
  Don't ask to install webpack for using Styleguidist (facebook#2656)
  Put react-scripts in dependencies, not devDependencies (facebook#2657)
  Razzle added to the alternatives (facebook#2517)
  Warn about large bundle sizes (facebook#2648)
  Add instructions to use source-map-explorer (facebook#1641)
  ...

# Conflicts:
#	packages/react-dev-utils/package.json
#	packages/react-scripts/config/webpack.config.dev.js
#	packages/react-scripts/config/webpack.config.prod.js
#	packages/react-scripts/package.json
@klzns
Copy link

klzns commented Jun 30, 2017

@gaearon Why the instructions changed from --save-dev to --save?

Aren't gh-pages, source-map-explorer, enzyme, react-test-renderer, jest-enzyme dev-dependencies?

@Timer Timer deleted the gaearon-patch-18 branch June 30, 2017 21:43
romaindso pushed a commit to romaindso/create-react-app that referenced this pull request Jul 10, 2017
* Minor code style edits to user guide

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md
wmonk referenced this pull request in wmonk/create-react-app-typescript Aug 7, 2017
* Minor code style edits to user guide

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md
morgs32 pushed a commit to BrickworkSoftware/create-react-app that referenced this pull request Sep 1, 2017
* Minor code style edits to user guide

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md
@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants