Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix external CSS imports #2680

Merged
merged 3 commits into from Jun 29, 2017

Conversation

Projects
None yet
2 participants
@gaearon
Copy link
Member

commented Jun 29, 2017

Fixes #2677.
Not sure why.

Would be nice to follow up with someone to figure it out.
cc @andykenward

@gaearon gaearon added this to the 1.0.9 milestone Jun 29, 2017

@gaearon gaearon referenced this pull request Jun 29, 2017

Closed

[not for merge] Fail CI #2681

@gaearon gaearon merged commit 567d981 into facebook:master Jun 29, 2017

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@gaearon gaearon referenced this pull request Jun 29, 2017

Merged

Changelog for 1.0.9 #2682

zangrafx added a commit to absolvent/create-react-app that referenced this pull request Jun 30, 2017

Merge remote-tracking branch 'upstream/master'
* upstream/master:
  Publish
  Changelog for 1.0.10 (facebook#2694)
  Update CHANGELOG.md
  Upgrade flow (facebook#2693)
  Added `gluestick` to the alternatives section (facebook#2402)
  Downgrade `strip-ansi` package to 3.0.1 (facebook#2692)
  Fix typo (facebook#2683)
  Fix typo in README link (facebook#2684)
  Publish
  Changelog for 1.0.9 (facebook#2682)
  Fix external CSS imports (facebook#2680)

# Conflicts:
#	packages/react-dev-utils/package.json
#	packages/react-scripts/package.json

romaindso added a commit to romaindso/create-react-app that referenced this pull request Jul 10, 2017

Fix external CSS imports (facebook#2680)
* Fix external CSS imports

* Add external CSS import to integration test

* Fix assertion

wmonk referenced this pull request in wmonk/create-react-app-typescript Aug 7, 2017

Fix external CSS imports (#2680)
* Fix external CSS imports

* Add external CSS import to integration test

* Fix assertion

morgs32 added a commit to BrickworkSoftware/create-react-app that referenced this pull request Sep 1, 2017

Fix external CSS imports (facebook#2680)
* Fix external CSS imports

* Add external CSS import to integration test

* Fix assertion

@lock lock bot locked and limited conversation to collaborators Jan 21, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.