Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add directory details to packages/* package.json #6826

Merged
merged 1 commit into from Apr 16, 2019

Conversation

@feelepxyz
Copy link
Contributor

commented Apr 16, 2019

Specifying the directory as part of the repository field in a
package.json allows third party tools to provide better support when
working with monorepos. For example, it allows them to correctly
construct a commit diff for a specific package.

This format was accepted by npm in npm/rfcs#19.

Add directory details to packages/* package.json
Specifying the directory as part of the repository field in a
package.json allows third party tools to provide better support when
working with monorepos. For example, it allows them to correctly
construct a commit diff for a specific package.

This format was accepted by npm in [npm/rfcs#19](npm/rfcs#19).

@ianschmitz ianschmitz added this to the 3.0 milestone Apr 16, 2019

@ianschmitz ianschmitz merged commit ced3fd4 into facebook:master Apr 16, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
netlify/create-react-app/deploy-preview Docs deploy preview succeeded
Details
@ianschmitz

This comment has been minimized.

Copy link
Collaborator

commented Apr 16, 2019

Thanks!

@mrmckeb

This comment has been minimized.

Copy link
Collaborator

commented Apr 17, 2019

Thanks @feelepxyz - can you provide details of any packages using this approach now (this is for my own interest) :)

@feelepxyz

This comment has been minimized.

Copy link
Contributor Author

commented Apr 17, 2019

@mrmckeb yes we're using at @dependabot to link to the package and commit view from the PRs we create. Here's an example: benbrandt/movie-list#14

@feelepxyz feelepxyz deleted the feelepxyz:add-repo-directory branch Apr 17, 2019

@lock lock bot locked and limited conversation to collaborators Apr 22, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.