-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: social cards #2968
Comments
Notes, there are many ways to handle these social cards.
Interesting blog post: https://www.swyx.io/writing/jamstack-og-images/
What I think about potential implementations: Generating the images at build timeWould require some kind of headless browser in the build process. I think it's likely to complicate the build process, make it slower, less portable, and potentially exceeding free quotas of popular free CIs. I think it's not the best solution. Seen this being done here with Gasby: Using a SaaSSome people are using a SaaS like Cloudinary to generate these cards, so they don't have to host any infrastructure. For example: Self hostedWe could create our own solution and host it. Other solutions are possible, but I mean forking https://github.com/vercel/og-image as a We would make the service flexible enough so that it works great for most of the sites, yet enabling users to self host an alternative service if our default service does not suit their needs. What I think we should do:
This way, we don't complicate the build by default, yet we enable users to craft their own social image urls. They could self-host their own fork of vercel/og-images, use external services like Cloudinary, or even add the image generation as a build step using a docusaurus postBuild plugin. |
hi! me and @Drewbi will be working on this issue :) |
Great! @anshulrgoyal also suggested we could simply use an image processing lib like |
I was suggesting creating some template for cards and then allowing the user to provide custom stuff like text, icons, logo, images cards and we can have templates that can read mark down and extract stuff from it like for blog we can extract image and title, author and create image from it. |
Yes, in the end we should be able to add a meta og image tag in generated pages + an image in the build folder. We also need to think about where we plug this image file generation step, we don't have anything like that in D2 afaik. Also need to think about how to make it generic so that it can work for docs, blog, pages... what's the url of such image etc... Not so simple :) |
I'd personally prefer customizing the existing og-image project as many of the features are very relevant to what we are trying to achieve and all that would be required in terms of modification would be altering the html/css that gets generated internally by the function. In order to integrate the process locally at build time we would have to create and store an image for every page and either keep track of updates or regenerate the images on the next build. While possible, at this point I feel the API would lend itself quite nicely to the job and would allow for a light weight and easy implementation. It would also allow for users to swap out endpoints if they want like @slorber mentioned. The customization of fields would be as easy as including or leaving out fields from the query string, eg. Either way, if we agree on some desirable fields, I can start creating designs/mockups 🎨 |
Some random thoughts. I think it should be integrated at the theme classic level. Other themes would be responsible for adding themselves the og image system they want (if they do). I think the theme should allow a function to generate the og image url for each page. It would take some data we provide as parameter const config {
themeConfig: {
createOGImage: ({data,defaultImage}) => {
if (data.type === "myCustomDocType" {
return "https://cloudinary.com/someThing?"+serialize({title: data: title});
}
return defaultImage; // defaultImage would be an url to the hosted og-docusaurus hosted service
}
}
} Eventually, we could allow the user to generate himself the images at build time using an async function? const config {
themeConfig: {
createOGImage: async (data) => {
const relativeFilePath = path.join("og_images",random()+".jpg");
const filePath = path.join(__dirname,"build","og_images",random()+".jpg");
await writeFile(filePathgenerateOgImageWithSharp(data));
return "https://myDocusaurusSite/"+baseUrl + relativeFilePath;
}
}
} This function couldn't be called from React directly (as the browser does not have access to nodejs apis like sharp/fs etc), so I think the blog/docs plugin should call it with the blog/doc metadata, and inject it into the theme components as props. (BlogPostPage/DocItem) Not totally sure about this api, feedbacks welcome. We should probably make the system generic enough so that it can be used as well for custom pages (+ the upcoming markdown pages: #2947). @Drewbi I think it's safe to say that we need at least 3 types of social cards:
I think the fields should vary according to the kind of docs, so we probably need multiple designs. In all cases I think including the site logo is nice, and an opt-out Docusaurus logo for growth hacking 🤪 |
@slorber I was thinking of adding it to some place like StaticSiteGenerator plugin. We can allow the user to modify options and pass a custom function that will be envoked inside ejs, with all the page meta data |
Some site bots don't render javascript |
That could be nice to see a poc of this, even if there are lots of things hardcoded in the PR, to see if it can fit the usecases. I think it's ok to use custom meta elements anyway so it shouldn't be a big deal, + we could make a Helmet wrapper to help the user provide us the data needed for custom pages.
I don't understand 😅 |
Made some initial experiments, am still not completely satisfied with any so will continue experimenting but figure I'd put them out there if anyone has suggestions for things to try or comments about which ones work best. For a closer look: |
That looks like a nice start, great. For versioned docs, I'd say we should make the version smaller and closer to the bottom. |
Yes @sarthakkundra thanks 👍 Do you have good design skills to make some proposals for the social cards? Also worth looking at existing PR draft code from former MLH (just for inspiration, does not mean we have to keep that existing code) |
@slorber I have terrible design skills :/ but there is an Adobe XD wireframe link in this thread which I can use? I think that'll go with OG-Vercel too as we can change Vercel's logo with D2's and probably play around with the font. I had a look at the PR. Will take inspiration from it once I've setup the Vercel API to return Images / SVGs based on our query string. Let me know if you have an implementation in mind or want to add something to this approach. |
I don't think you need to master a design tool, as long as you can make a pretty html/css card that's already nice I don't have much more API ideas that what is written here (it's been a long time I didn't think about this problem). |
Sounds good! |
@sarthakkundra I also built a POC but it explored an alternate approach, it might worth looking into. https://github.com/MLH-Fellowship/docusaurus/tree/anshul/ogimage |
@slorber Made some mockups. Let me know the feedback, will modify og-Vercel accordingly to create our Image as a service provider which we can later host. Social Cards Mockup Check out this codepen for background options |
Thanks, that looks nice. |
Hey @slorber, I managed to get a working instance of this social cards feature working on my own site. I used the vercel og image tool. It works a charm. A way I have done it is by adding this file: here What are your thoughts on this design? |
@PatelN123 ideally you should not need to use swizzle on the Seo component to provide the social cards feature Also, we want it to be flexible, so ideally the user should be able to provide a callback directly in the config to generate the social card URL, adapting to any card service (not just the one we suggest). Eventually, we could even provide a lightweight package that builds social cards as part of the build process locally |
I would like to work on this. I was able to get passing in a function working, but only inside of the main docusaurus.config.js, but not inside the theme config. Inside of the theme config, the function is evaluated to a string rather than returning a callback. I think that this is because theme data must be serialized to plain strings. Is it fine to leave the function inside the main config? |
@dpang314 yes, if it's actually accessed on server-side (and I hope it is!), you can put it in main config... for now. The actual API design can be deferred. A working prototype is fine. |
I have a proof of concept that is deployed here: https://capable-belekoy-059ce2.netlify.app/ Currently I haven’t fully implemented it, but it should work for all doc besides tag pages. It won't be difficult to apply the same implementation to tags, JSX/MDX, pages, and blogs. A few examples: I am generating the image url using the callback inside the doc plugin and adding it to doc metadata, which is then passed to the doc components that in turn pass the props to the existing component. I plan to do the same for the other plugins. Will this implementation be feasible? |
@dpang314 I'd like to see the code to be able to tell :) But that looks to be working so that's a goot start 👍 What matters most is to have a good/flexible public API. If it's not possible to find the best API today, we can still ship this as an experimental version and do breaking changes later if we have a better approach. |
Link to the code. I have a lot to clean up and add, but the basic implementation is there. |
@rotemtam implemended social cards in userland with swizzle: ariga/atlas#1201 I hope we can find a good API for this feature, in the meantime it is definitively possible and quite easy to implement in userland ;) |
Linking this for reference: https://github.com/vercel/satori |
anybody have video tutorial i don't [really] understand im noob , Tell me how to create Square image preview for facebook Check here the sample dont know how it works - click |
Has anyone gotten satori working with Docusaurus? |
@nandorojo I have. The Satori instance itself is at https://github.com/anaclumos/og |
when sharing on social media, this image is used in the social media post. see also https://docusaurus.io/blog/2022/08/01/announcing-docusaurus-2.0#whats-next facebook/docusaurus#2968
I tried adding a static social card but the option "image" is unrecognized by docusaurus v^2.0 and I can't seem to find any documentation about adding (global) social cards here: https://docusaurus.io/docs/seo trace:
|
I'll be investigating this for our work over on excaliburjs/Excalibur and we are on CF Pages; which means I think we could bake this into a Cloudflare Pages Function to handle (and they have a generous free tier + we can take advantage of CDN caching). As another alternative to Vercel. I haven't looked over it in detail, I've only skimmed over the thread. |
Just my few cents, since I found this issue. How about using JSX like everything in Docusaurs and create SVG file out of it. Then render it into pure SVG file that is then converted to png. But only on Note that I can do this on my own, but I only needs hooks into the Docusaurs system, the API that will trigger on every build that I can access blog data, similar to RSS. I could probably abuse RSS for this, but Docusaurs may complain that the image file is missing when it builds the site. |
Note for context we are resuming work on this feature.
If you look at my answer here: #9941 Here's @OzakIOne POC: OzakIOne/local-og-image-generator#1 We'll deploy that to an edge runtime letting you customize things with query string parameters, and try to see if we could partner with a host like Vercel to provide this feature as a service. And we'll also expose the ability to generate images through a Node API for those that do And we'll make the repo easy to fork, customize and deploy yourself, in case our default design and customization options are not good enough.
For sure, cf the PR above, generating images can be done in userland.
Actually... that's the complicated part here 😅 How do we design those hooks so that we allow users to be able to generate images through a Node.js lib, or generate URLs targeting a remote image service endpoint. How do we make it efficient so that rebuilding your site takes less time? How does it work for MDX docs? And how does it work for pure JSX pages? For both Node API calls and remote service urls. How do we enable third-party plugin authors to leverage this without too much boilerplate and the risk of having diverging integrations? Can we figure out how to enable this on third-party plugins, without even their authors having to write code? These are the questions to answer. If you have those answers, let me know 😄 |
I've successfully generate social card in userland. By adding code to Here is an example Card: N/A is because of missing date of the blog post. The code look like this: createFeedItems: async ({ blogPosts,...params }) => {
if (isProd) {
await Promise.all(blogPosts.map(blogPost => {
const slug = blogPost.metadata.permalink.replace(/^.*\//, '');
const title = blogPost.metadata.title;
const fullname = 'Jakub T. Jankiewicz';
const avatar = 'https://github.com/jcubic.png';
return renderSocialCard({ title, fullname, avatar, slug });
}));
}
const feedItems = await params.defaultCreateFeedItems({ blogPosts, ...params });
feedItems.forEach((feedItem,index) => {
const blogPost = blogPosts[index]!;
const permalink = blogPost.metadata.permalink;
const excerpt = blogPost.content.replace(/<!--\s*truncate\s*-->[\s\S]*$/, '').trim();
const html = (marked.parse(excerpt) as string) + `<br/><a href="${permalink}">see the rest of the article</a>`
feedItem.content = html;
});
return feedItems;
} is located here: https://github.com/jcubic/lips-website/tree/docusaurus/docs it uses render function from src/utils.ts that do all the job. The reason why I use puppeteer is that I Have foreign object with HTML inside (p tag) to have proper line wrapping and I think it requires real browser. It doesn't render in Inkscape. So what is missing:
|
People here want to generate social cards for docs and third-party plugins too, and not just blog RSS entries. The solution we will implement can't be based on that. |
Sure, but the API can be literally the same, it only needs to be triggered on every page instead of only blog posts, and you need to pick a good name. I also find all missing properties except |
@jcubic "it only" assumes it's easy, but from what I read you don't plainly understand the problem space, and only see your use case while we try to generalize a solution. This feature is not related to the blog, not related to the feed. Our other plugins and third-party plugins might as well have a behavior that is far from how the blog plugin works, so don't think that a solution for a blog could be generalized that easily. Unlike blog posts, docs have versions. It is not just a "list of items" on which there is an image attribute to set. We already have a We produce pages for which we might want to generate a custom social card, that do not even belong to a Markdown document or React page component. This is notably the case for blog tags pages, blog paginated lists, blog archive page, upcoming blog authors pages, docs autogenerated categories, and more fancy pages that we could create in the future. |
Issue for idea already expressed here: #2267 (comment)
Dynamic Social Cards
You might have noticed that some people / companies have an automated way to generate social cards that adapt to the underlying content (generating an image from query string params)
I think this would cool if by default, all Docusaurus docs/blogs would generate custom social cards, if the user did not define any custom social image.
This way, all Docusaurus links pasted to a social media would have a beautiful image.
By default we could even include a discrete Docusaurus + Slash logo for growth hacking 🤪
Vercel has a nice project to do this easily: https://github.com/vercel/og-image
We could fork this project, host our own variant (can be free on Vercel), and use it for D2 website, + allow other sites to use it as well.
Curretly, Docusaurus can have a default social card, but it's static and does not adapt to the content::
Here's some examples of dynamic/automated social cards:
The text was updated successfully, but these errors were encountered: