Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): add syntax highlight to generated colors #2114

Merged
merged 1 commit into from
Dec 10, 2019

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Dec 10, 2019

Motivation

In addition to the syntax highlighting itself, which is important given the dark/light Prism theme (coming soon #1984), it is possible to copy CSS vars simply click button.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

image

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@lex111 lex111 added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Dec 10, 2019
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Dec 10, 2019
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-preview ready!

Built with commit 3f26887

https://deploy-preview-2114--docusaurus-preview.netlify.com

@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit 3f26887

https://deploy-preview-2114--docusaurus-2.netlify.com

Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this ❤️

@yangshun yangshun merged commit 1f0eb37 into facebook:master Dec 10, 2019
@endiliey
Copy link
Contributor

approved

@endiliey endiliey added pr: documentation This PR works on the website or other text documents in the repo. and removed pr: maintenance This PR does not produce any behavior differences to end users when upgrading. labels Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants