-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(v2): upgrade Infima and remark-admonitions #2372
Conversation
body > #__docusaurus { | ||
height: 100%; | ||
#__docusaurus { | ||
min-height: 100%; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is needed for working the sticky position.
@@ -234,6 +234,10 @@ | |||
} | |||
} | |||
|
|||
.algolia-autocomplete pre { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Algolia adds this invisible pre element, and our built-in styles add padding due to which extra spaces appears to the right on the mobiles (due to sticky positioned navbar)
Deploy preview for docusaurus-2 ready! Built with commit 51ef99f |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome thank you!
Motivation
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Preview.
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)