Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(v2): upgrade Infima and remark-admonitions #2372

Merged
merged 2 commits into from
Mar 7, 2020

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Mar 7, 2020

Motivation

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Preview.

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@lex111 lex111 added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Mar 7, 2020
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 7, 2020
body > #__docusaurus {
height: 100%;
#__docusaurus {
min-height: 100%;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is needed for working the sticky position.

@@ -234,6 +234,10 @@
}
}

.algolia-autocomplete pre {
Copy link
Contributor Author

@lex111 lex111 Mar 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Algolia adds this invisible pre element, and our built-in styles add padding due to which extra spaces appears to the right on the mobiles (due to sticky positioned navbar)

@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Mar 7, 2020

Deploy preview for docusaurus-2 ready!

Built with commit 51ef99f

https://deploy-preview-2372--docusaurus-2.netlify.com

Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thank you!

@yangshun yangshun merged commit 31b0ce6 into master Mar 7, 2020
@yangshun yangshun deleted the lex111/upgrade-infima branch March 8, 2020 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navbar line break in create react app docusaurus site
4 participants