fix(v2): Do not automatically change tab when a non-existing option is selected #2893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for docusaurus-2 ready! Built with commit 9cd42c5 |
lex111
approved these changes
Jun 6, 2020
yangshun
approved these changes
Jun 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Address #2885.
When a tab group choice is updated, the updated choice might not be available in some tab groups. In the current implementation, it will just appear that nothing is chosen, which might look confusing. This diff changes the behavior so that it will avoid updating a local tab choice when a tab group choice chooses an non-existing option.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
See the added docs. When I select Linux which doesn't exist in the above two tab groups, those groups' tab choices don't change.
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)