feat(v2): add style property to theme-classic navbar #3432
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There are Docusaurus users which will prefer the static Navbar design. The idea for this was based on Footer
style
property, but due toinfima
restrictions this PR evolved a bit.The current implementation offers users two style override options -
dark
andprimary
. There are based on the classes thatinfima
provides (I'm not familiar with this package at all).@slorber I would be nice to implement
light
theme too, but at this moment I'm not sure how to do this cleanly (what's the best way), but I can work on this further with some amount of guidance.I have also removed
'navbar--light'
class because it was always (so wrongly) included and there is no CSS code associated with that class.This PR also updates the docs and adds new section related to this property.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Feature has been test on the local Docusaurus V2 website.
Related PRs
Preview
Dark
Primary