Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): escape alt text in img tag #3757

Merged
merged 1 commit into from
Nov 16, 2020
Merged

fix(v2): escape alt text in img tag #3757

merged 1 commit into from
Nov 16, 2020

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Nov 16, 2020

Motivation

Fixes #3751

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Tests

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@lex111 lex111 added the pr: bug fix This PR fixes a bug in a past release. label Nov 16, 2020
@lex111 lex111 requested a review from slorber as a code owner November 16, 2020 13:33
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 16, 2020
@netlify
Copy link

netlify bot commented Nov 16, 2020

Deploy preview for docusaurus-2 ready!

Built with commit 98bfa81

https://deploy-preview-3757--docusaurus-2.netlify.app

@slorber
Copy link
Collaborator

slorber commented Nov 16, 2020

LGTM 👍

@slorber slorber merged commit 311be6e into master Nov 16, 2020
@lex111 lex111 deleted the lex111/iss3751 branch November 17, 2020 15:01
@lex111 lex111 added this to the v2.0.0-alpha.67 milestone Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v2] Fails to build if markdown image alt-text has double quotes
3 participants