refactor(v2): correct plugin types #4418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armano2
changed the title
|
Deploy preview for docusaurus-2 ready! Built without sensitive environment variables with commit de36444 |
|
Lighthouse Report is failing :( |
|
[V1] Deploy preview failure Built without sensitive environment variables with commit de36444 https://app.netlify.com/sites/docusaurus-1/deploys/604be7d5ab87570007359a84 |
1 similar comment
|
[V1] Deploy preview failure Built without sensitive environment variables with commit de36444 https://app.netlify.com/sites/docusaurus-1/deploys/604be7d5ab87570007359a84 |
slorber
reviewed
Mar 15, 2021
| @@ -114,7 +115,7 @@ For more information, visit https://v2.docusaurus.io/docs/using-plugins.`); | |||
| version: pluginVersion, | |||
| }; | |||
| }) | |||
| .filter(Boolean); | |||
| .filter(<T>(item: T): item is Exclude<T, null> => Boolean(item)); | |||
There was a problem hiding this comment.
will merge this, but if you can add a utility fn in docusaurus-utils that would be appreciated :)
https://kentcdodds.com/blog/typescript-function-syntaxes#type-guards
slorber
added
the
pr: polish
|
Thanks 👍 |
This was referenced Mar 17, 2021
Closed
Merged
This was referenced Mar 17, 2021
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Improve types in docusaurus,
Have you read the Contributing Guidelines on pull requests?
yes