Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): add a missing slug from the initial template #4561

Merged

Conversation

Foxeye-Rinx
Copy link
Contributor

Motivation

Improve the initial template. (classic template)

After creating the initial template, the guide shows on the http://localhost:3000/docs/create-a-blog-post
says the created blog will be available at http://localhost:3000/blog/greetings, but it's not, because of lacking of a slug config on the metadata of the md file.

This commit adds the missing slug config

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)

Related PRs

#4320

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 2, 2021
@netlify
Copy link

netlify bot commented Apr 2, 2021

@github-actions
Copy link

github-actions bot commented Apr 2, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 76
🟢 Accessibility 96
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4561--docusaurus-2.netlify.app/

@slorber slorber changed the title doc(v2): add a missing slug from the initial template docs(v2): add a missing slug from the initial template Apr 5, 2021
@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Apr 5, 2021
@slorber
Copy link
Collaborator

slorber commented Apr 5, 2021

thanks!

@slorber slorber merged commit ddcdb1c into facebook:master Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants