Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): wrap mdx usage in mdx-code-block #5007

Merged
merged 1 commit into from
Jun 18, 2021

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Jun 18, 2021

Motivation

Crowdin-related issues due to unescaped MDX usage, preventing the site to deploy: https://app.netlify.com/sites/docusaurus-2/deploys/60ccbb53d7e132000849fc0b

image

We should use ```mdx-code-block around JSX in md

@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Jun 18, 2021
@slorber slorber requested a review from lex111 as a code owner June 18, 2021 15:54
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jun 18, 2021
@netlify
Copy link

netlify bot commented Jun 18, 2021

✔️ [V2]

🔨 Explore the source changes: 2af73e3

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/60ccc1b82e8cbd0007ac1686

😎 Browse the preview: https://deploy-preview-5007--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 65
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5007--docusaurus-2.netlify.app/

@slorber slorber merged commit c63295a into master Jun 18, 2021
@github-actions
Copy link

Size Change: 0 B

Total Size: 569 kB

ℹ️ View Unchanged
Filename Size Change
website/build/assets/css/styles.********.css 87.8 kB 0 B
website/build/assets/js/main.********.js 385 kB 0 B
website/build/blog/2017/12/14/introducing-docusaurus/index.html 65.8 kB 0 B
website/build/docs/introduction/index.html 235 B 0 B
website/build/index.html 30.5 kB 0 B

compressed-size-action

@slorber slorber deleted the slorber/wrap-mdx-for-crowdin branch August 17, 2021 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants