fix(v2): sitemap should respect the global trailingSlash config option. #5068
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Sitemap has a depricated option,
trailingSlash
. When used, URLs in the sitemap have trailing slashes, but you see a warning:If you remove the
trailingSlash
option from the sitemap plugin, and instead have a globaltrailingSlash
option set totrue
, the generated sitemap lacks trailing slashes.This PR causes the sitemap plugin to respect the global
trailingSlash
option.Have you read the Contributing Guidelines on pull requests?
yes
Test Plan
Within
website
I explicitly set the globaltrailingSlash
option to true, and then false, to verify that trailing slashes are generated (or not) respectively.