chore: upgrade Infima to alpha.30 #5256
Conversation
lex111
added
the
pr: maintenance
|
✔️ [V2] 🔨 Explore the source changes: 1feac16 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61137a86c854ae0007126d60 😎 Browse the preview: https://deploy-preview-5256--docusaurus-2.netlify.app |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-5256--docusaurus-2.netlify.app/ |
|
Size Change: -296 B (0%) Total Size: 792 kB
ℹ️ View Unchanged
|
| @@ -88,7 +88,7 @@ function DropdownNavbarItemDesktop({ | |||
| 'dropdown--show': showDropdown, | |||
| })}> | |||
| <NavLink | |||
| className={clsx('navbar__item navbar__link', className)} | |||
There was a problem hiding this comment.
This removes some padding leading to a different alignment, should we restore this padding or we don't want it on purpose?
I think it make sense to remove this padding but maybe we should provide a way to align the dropdown in a centered way instead of left/right
CF RN website upgrade
There was a problem hiding this comment.
my fault, didn't notice it, just made fix for it facebookincubator/infima#168
There was a problem hiding this comment.
Thanks
Also there's a bit less vertical spacing.
Not sure it's intended and have no strong opinion, but I prefer with a bit more spacing like before 🤪
There was a problem hiding this comment.
It's hard to say, but if you want to increase spacing, I don't mind.
Motivation
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Preview
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)