fix: show secondary menu if even there is no main one #5262
Conversation
|
Maybe we should move the color toggle to navbar on mobiles? For example, when there are no navbar items, sidebar icon will not be displayed, consequently users will not have ability to switch color mode. Actually, when there are navbar items it is not immediately obvious that site has color toggle, this will be clearly seen only if user open mobile sidebar.
|
|
✔️ [V2] 🔨 Explore the source changes: ce2e3a5 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61050a04d5c74e0007a719cd 😎 Browse the preview: https://deploy-preview-5262--docusaurus-2.netlify.app |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-5262--docusaurus-2.netlify.app/ |
|
Size Change: -6 B (0%) Total Size: 905 kB ℹ️ View Unchanged
|
|
Thanks 👍 looks great
That would be a quite specific case to handle. An empty navar is unusual and the user reported that , was only using the docs-only mode. I suggest we wait for someone to come-up with the need for this before we implement something that nobody would use :) |
Motivation
A quick attempt to fix #5241
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Remove all navbar items in config file and go to docs page. Note that on regular pages such as homepage or blog pages, sidebar icon will not be displayed.
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)