Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: try to make plugin/preset config less confusing #5313

Merged
merged 1 commit into from
Aug 10, 2021

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Aug 6, 2021

Motivation

Make it easier to understand that there are 2 ways to configure content plugins, and most users should use the preset config.

See confusion here: #5246 (comment)

Preview: https://deploy-preview-5313--docusaurus-2.netlify.app/docs/next/api/plugins/@docusaurus/plugin-content-docs/

@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Aug 6, 2021
@slorber slorber requested a review from lex111 as a code owner August 6, 2021 17:56
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Aug 6, 2021
@netlify
Copy link

netlify bot commented Aug 6, 2021

✔️ [V2]

🔨 Explore the source changes: 85fd0a9

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/610d77d7fcbfd000073dbe26

😎 Browse the preview: https://deploy-preview-5313--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Aug 6, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 79
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5313--docusaurus-2.netlify.app/

@github-actions
Copy link

github-actions bot commented Aug 6, 2021

Size Change: -2 B (0%)

Total Size: 792 kB

ℹ️ View Unchanged
Filename Size Change
website/.docusaurus/globalData.json 36.1 kB 0 B
website/build/assets/css/styles.********.css 93.2 kB 0 B
website/build/assets/js/main.********.js 403 kB 0 B
website/build/blog/2017/12/14/introducing-docusaurus/index.html 63.9 kB 0 B
website/build/blog/index.html 33.1 kB 0 B
website/build/docs/index.html 41.9 kB -1 B (0%)
website/build/docs/installation/index.html 49.6 kB -1 B (0%)
website/build/index.html 28.7 kB 0 B
website/build/tests/docs/index.html 22.6 kB 0 B
website/build/tests/docs/standalone/index.html 20.5 kB 0 B

compressed-size-action

@slorber
Copy link
Collaborator Author

slorber commented Aug 6, 2021

@lex111 @Josh-Cena any opinion on this doc structure?

@lex111
Copy link
Contributor

lex111 commented Aug 6, 2021

@slorber looks good to me, that's much better!

@Josh-Cena
Copy link
Collaborator

@slorber LGTM!

@slorber
Copy link
Collaborator Author

slorber commented Aug 10, 2021

thanks 👍

@slorber slorber merged commit 1257e99 into master Aug 10, 2021
@slorber slorber deleted the slorber/doc-preset-content-plugins branch August 10, 2021 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants