Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: e2e tests should stay on Yarn v2 for now #5340

Closed
wants to merge 11 commits into from

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Aug 11, 2021

Motivation

yarn set version berry now picks Yarn v3 instead of v2, and e2e tests time out, so we'll figure out how to bring Yarn 3 support in a separate PR

Example CI failures:

Have you read the Contributing Guidelines on pull requests?

yes

Test Plan

ci

@slorber slorber added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Aug 11, 2021
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Aug 11, 2021
@netlify
Copy link

netlify bot commented Aug 11, 2021

✔️ [V2]

🔨 Explore the source changes: c2ae22a

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61140454b7d9ec0008d08640

😎 Browse the preview: https://deploy-preview-5340--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Aug 11, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 80
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5340--docusaurus-2.netlify.app/

@github-actions
Copy link

github-actions bot commented Aug 11, 2021

Size Change: 0 B

Total Size: 793 kB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 36.2 kB
website/build/assets/css/styles.********.css 93.1 kB
website/build/assets/js/main.********.js 403 kB
website/build/blog/2017/12/14/introducing-docusaurus/index.html 64.2 kB
website/build/blog/index.html 33.1 kB
website/build/docs/index.html 41.9 kB
website/build/docs/installation/index.html 49.6 kB
website/build/index.html 28.7 kB
website/build/tests/docs/index.html 22.5 kB
website/build/tests/docs/standalone/index.html 20.5 kB

compressed-size-action

@Josh-Cena
Copy link
Collaborator

Josh-Cena commented Aug 11, 2021

Don't think CI times out because of this though, I ran the same workflow on my machine and it returns normally

image

P.S. I'm on yarn v3 and it's still good 😅 So mysterious

image

@slorber slorber requested a review from lex111 as a code owner August 11, 2021 16:26
@slorber
Copy link
Collaborator Author

slorber commented Aug 11, 2021

@Josh-Cena this is driving me crazy :D

Note:

  • setting yarn version from Yarn 1 does not work at first, you have to first switch to berry, then set appropriate version

I can reproduce the issue locally with:

rm -rf my-website-canary

npx @docusaurus/init@canary init my-website-canary classic --skip-install

cd my-website-canary


rm -rf node_modules yarn.lock .yarn .yarnrc.yml
yarn -v

yarn set version berry
yarn -v

yarn set version 2.4.2
yarn -v
yarn config set pnpMode loose
yarn config set enableGlobalCache true

yarn install

yarn start

@slorber
Copy link
Collaborator Author

slorber commented Aug 12, 2021

closing in favor of #5342

@slorber slorber closed this Aug 12, 2021
@slorber slorber deleted the slorber/fix-e2e-tests branch August 17, 2021 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants