Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: code blocks should scroll in RTL direction #5357

Merged
merged 1 commit into from
Aug 13, 2021

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Aug 13, 2021

Motivation

Fix #5324

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Aug 13, 2021
@slorber slorber requested a review from lex111 as a code owner August 13, 2021 16:11
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Aug 13, 2021
@slorber slorber mentioned this pull request Aug 13, 2021
5 tasks
@netlify
Copy link

netlify bot commented Aug 13, 2021

✔️ [V2]

🔨 Explore the source changes: a559af2

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/611699c788074e00080dd454

😎 Browse the preview: https://deploy-preview-5357--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 74
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5357--docusaurus-2.netlify.app/

@github-actions
Copy link

Size Change: 0 B

Total Size: 803 kB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 36.2 kB
website/build/assets/css/styles.********.css 93.9 kB
website/build/assets/js/main.********.js 405 kB
website/build/blog/2017/12/14/introducing-docusaurus/index.html 65.3 kB
website/build/blog/index.html 34.2 kB
website/build/docs/index.html 43 kB
website/build/docs/installation/index.html 50.6 kB
website/build/index.html 29.8 kB
website/build/tests/docs/index.html 23.6 kB
website/build/tests/docs/standalone/index.html 21.6 kB

compressed-size-action

@slorber slorber merged commit 416e2a7 into master Aug 13, 2021
@slorber slorber deleted the slorber/fix-rtl-code-block-scroll branch August 13, 2021 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

code block in rtl doesn't scroll
2 participants