polish: remove unused eslint-disable #5560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ [V2] 🔨 Explore the source changes: 05fb823 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61498f58321b6700071c644d 😎 Browse the preview: https://deploy-preview-5560--docusaurus-2.netlify.app |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-5560--docusaurus-2.netlify.app/ |
Josh-Cena
force-pushed
the
remove-eslint-disable
branch
from
aa69106
to
d367d22
Compare
slorber
added
the
pr: polish
|
Thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Unused
eslint-disablenot only adds excess noise but also hides away future errors. Also a lot of the rules were simply disabled globally through.eslintrc.js, so the in-line disables are of no use.We should enforce this by adding
to the CI
Have you read the Contributing Guidelines on pull requests?
Yes