Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused Bootstrap theme #5634

Merged
merged 6 commits into from
Oct 1, 2021
Merged

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Oct 1, 2021

Motivation

The Bootstrap theme/preset has never been production-ready and is not used by anyone.

It is totally broken today because we don't have yet the infra to share enough code across themes.

After internal discussions, we decided to remove it from the repo.

Due to significant traction, it's likely that the 2nd production-ready Docusaurus theme will be the Tailwind one: #2961

It's also likely that we'll only provide 2 official themes to reduce maintenance, and delegate the implementation of an eventual Bootstrap theme to the community

@slorber slorber added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Oct 1, 2021
@slorber slorber requested a review from lex111 as a code owner October 1, 2021 14:36
@netlify
Copy link

netlify bot commented Oct 1, 2021

✔️ [V2]

🔨 Explore the source changes: c65e828

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61571cd69200050007bde745

😎 Browse the preview: https://deploy-preview-5634--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Oct 1, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 74
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5634--docusaurus-2.netlify.app/

@github-actions
Copy link

github-actions bot commented Oct 1, 2021

Size Change: -671 B (0%)

Total Size: 834 kB

Filename Size Change
website/.docusaurus/globalData.json 38.3 kB -185 B (0%)
website/build/assets/js/main.********.js 420 kB -488 B (0%)
ℹ️ View Unchanged
Filename Size Change
website/build/assets/css/styles.********.css 93.8 kB 0 B
website/build/blog/2017/12/14/introducing-docusaurus/index.html 67 kB 0 B
website/build/blog/index.html 38.1 kB 0 B
website/build/docs/index.html 44.6 kB +1 B (0%)
website/build/docs/installation/index.html 52.8 kB +1 B (0%)
website/build/index.html 30.8 kB 0 B
website/build/tests/docs/index.html 25.5 kB 0 B
website/build/tests/docs/standalone/index.html 22.9 kB 0 B

compressed-size-action

Copy link
Contributor

@lex111 lex111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Probably you could create new GH org to move bootstrap theme there? Maybe that would be useful for the community.

docusaurus-community sounds great as org name, and later (after they officially approved) you would transfer/share the ownership org with FB.

@Josh-Cena
Copy link
Collaborator

Josh-Cena commented Oct 1, 2021

Not even BC? 😄
I guess the impact is High (stops working entirely) * 0% (~No usage) = 0, so maybe not BC

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Oct 1, 2021
@slorber slorber added the pr: breaking change Existing sites may not build successfully in the new version. Description contains more details. label Oct 1, 2021
@slorber
Copy link
Collaborator Author

slorber commented Oct 1, 2021

Added Breaking Change but IMHO it won't affect anyone anyway 🤪

docusaurus-community sounds great as org name, and later (after they officially approved) you would transfer/share the ownership org with FB.

According to our recent discussions, Facebook is more likely create a "docusaurus-core" org for support packages we have in the scope of Docusaurus (the existing forks, slorber/docusaurus-starter and other deps like admonition that we use internally).

I doubt that a docusaurus-community org will be created, or at least it would have to be self-organized, and FB doesn't necessarily want ownership of the packages

@slorber slorber merged commit a0c2c52 into main Oct 1, 2021
@slorber slorber deleted the slorber/remove-bootstrap-theme branch October 1, 2021 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: breaking change Existing sites may not build successfully in the new version. Description contains more details. pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants