-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove unused Bootstrap theme #5634
Conversation
✔️ [V2] 🔨 Explore the source changes: c65e828 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61571cd69200050007bde745 😎 Browse the preview: https://deploy-preview-5634--docusaurus-2.netlify.app |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-5634--docusaurus-2.netlify.app/ |
Size Change: -671 B (0%) Total Size: 834 kB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Probably you could create new GH org to move bootstrap theme there? Maybe that would be useful for the community.
docusaurus-community sounds great as org name, and later (after they officially approved) you would transfer/share the ownership org with FB.
Not even BC? 😄 |
Added Breaking Change but IMHO it won't affect anyone anyway 🤪
According to our recent discussions, Facebook is more likely create a "docusaurus-core" org for support packages we have in the scope of Docusaurus (the existing forks, slorber/docusaurus-starter and other deps like admonition that we use internally). I doubt that a docusaurus-community org will be created, or at least it would have to be self-organized, and FB doesn't necessarily want ownership of the packages |
Motivation
The Bootstrap theme/preset has never been production-ready and is not used by anyone.
It is totally broken today because we don't have yet the infra to share enough code across themes.
After internal discussions, we decided to remove it from the repo.
Due to significant traction, it's likely that the 2nd production-ready Docusaurus theme will be the Tailwind one: #2961
It's also likely that we'll only provide 2 official themes to reduce maintenance, and delegate the implementation of an eventual Bootstrap theme to the community