Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove some useless code #6118

Merged
merged 1 commit into from
Dec 17, 2021
Merged

refactor: remove some useless code #6118

merged 1 commit into from
Dec 17, 2021

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Dec 16, 2021

Motivation

Just a little cleaning up of codebase.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Preview

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@lex111 lex111 added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Dec 16, 2021
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Dec 16, 2021
@netlify
Copy link

netlify bot commented Dec 16, 2021

✔️ [V2]

🔨 Explore the source changes: 7c33f2c

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61bba8027fc74f000741b6e2

😎 Browse the preview: https://deploy-preview-6118--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 89
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-6118--docusaurus-2.netlify.app/

@github-actions
Copy link

Size Change: -27 B (0%)

Total Size: 652 kB

ℹ️ View Unchanged
Filename Size Change
website/.docusaurus/globalData.json 37.8 kB 0 B
website/build/assets/css/styles.********.css 101 kB 0 B
website/build/assets/js/main.********.js 484 kB -27 B (0%)
website/build/index.html 29.3 kB 0 B

compressed-size-action

@Josh-Cena
Copy link
Collaborator

Just wondering: where was useLocationHash used previously? Could it actually be useful in some cases and be added to theme-common?

@lex111
Copy link
Contributor Author

lex111 commented Dec 17, 2021

Don't think we need this hook, it's too specific, usually useLocationChange covers all needs.

@Josh-Cena Josh-Cena merged commit 6ab4efe into main Dec 17, 2021
@Josh-Cena Josh-Cena deleted the lex111/remove-dead-code branch December 17, 2021 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants