Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(content-docs): restore behavior when pagination front matter is null #6124

Merged
merged 2 commits into from
Dec 18, 2021

Conversation

Josh-Cena
Copy link
Collaborator

Motivation

Fix #6103

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Added one fixture test

@Josh-Cena Josh-Cena added the pr: bug fix This PR fixes a bug in a past release. label Dec 18, 2021
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Dec 18, 2021
@netlify
Copy link

netlify bot commented Dec 18, 2021

✔️ [V2]

🔨 Explore the source changes: a5081e5

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61bd41dcc4488c000736e849

😎 Browse the preview: https://deploy-preview-6124--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Dec 18, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 74
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-6124--docusaurus-2.netlify.app/

@github-actions
Copy link

github-actions bot commented Dec 18, 2021

Size Change: 0 B

Total Size: 652 kB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 37.8 kB
website/build/assets/css/styles.********.css 101 kB
website/build/assets/js/main.********.js 484 kB
website/build/index.html 29.3 kB

compressed-size-action

@netlify
Copy link

netlify bot commented Dec 18, 2021

✔️ [V2]

🔨 Explore the source changes: 165ac7f

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61bd433576e7e40007443599

😎 Browse the preview: https://deploy-preview-6124--docusaurus-2.netlify.app

@Josh-Cena Josh-Cena merged commit a5d2815 into main Dec 18, 2021
@Josh-Cena Josh-Cena deleted the jc/fix-pagination branch December 18, 2021 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pagination_next / prev no longer working
2 participants