docs: elaborate on "docs-only" and "blog-only" #6131
Conversation
himanshu007-creator
requested review from
Josh-Cena,
lex111 and
slorber
as code owners
|
I did mention in the issue that "we still need to rephrase it" but here I see a verbatim copy with some contents not even in the right place😅 Anyways, I would take this over and you can sit back while I do the edits before merging. Hope your love for opensource can take you far! |
Josh-Cena
added
the
pr: documentation
Josh-Cena
changed the title
|
✔️ [V2] 🔨 Explore the source changes: fa70db6 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61bfda3df8b8a5000871bf27 😎 Browse the preview: https://deploy-preview-6131--docusaurus-2.netlify.app |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-6131--docusaurus-2.netlify.app/ |
| @@ -328,7 +328,7 @@ authors: | |||
| The configuration file can be localized, just create a localized copy of it at: | |||
|
|
|||
| ```bash | |||
| website/i18n/<locale>/docusaurus-plugin-content-blog/authors.yml | |||
There was a problem hiding this comment.
this is a syntax we use on quite a few places, changing it only there makes it inconsistent.
We should either change it everywhere, or nowhere. I suggest to revert this change
There was a problem hiding this comment.
The mustache syntax is also used in quite a few places (at least when talking about category index pages). I made this change because it disrupts my local MDX syntax highlighting (silvenon/vscode-mdx#22) 🤦♂️
I suggest we collect all usage of such placeholder and try to normalize them. I would prefer single braces to either mustache or angle brackets.
There was a problem hiding this comment.
agree for normalization. I don't have a strong opinion on which syntax to use
Motivation
Love for opensource and trying out new things
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)