Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: mention configureWebpack devServer return value #6881

Merged
merged 1 commit into from
Mar 9, 2022

Conversation

Josh-Cena
Copy link
Collaborator

@Josh-Cena Josh-Cena commented Mar 9, 2022

Motivation

This was added in #6107, and although Configuration.devServer is already a thing, I figured that mentioning in documentation is worthwhile.

Have you read the Contributing Guidelines on pull requests?

Yes

@Josh-Cena Josh-Cena added the pr: documentation This PR works on the website or other text documents in the repo. label Mar 9, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 9, 2022
@netlify
Copy link

netlify bot commented Mar 9, 2022

✔️ [V2]

🔨 Explore the source changes: a010229

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/622899ee0e9fbb00085ae02c

😎 Browse the preview: https://deploy-preview-6881--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Mar 9, 2022

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 59
🟢 Accessibility 100
🟢 Best practices 92
🟢 SEO 100
🟢 PWA 90

Lighthouse ran on https://deploy-preview-6881--docusaurus-2.netlify.app/

@Josh-Cena Josh-Cena changed the title docs: add configureWebpack devServer return value to docs and types docs: add configureWebpack devServer return value to docs Mar 9, 2022
@Josh-Cena Josh-Cena changed the title docs: add configureWebpack devServer return value to docs docs: mention configureWebpack devServer return value Mar 9, 2022
@Josh-Cena Josh-Cena merged commit 2a7120c into main Mar 9, 2022
@Josh-Cena Josh-Cena deleted the jc/configurewebpack-type branch March 9, 2022 12:23
@github-actions
Copy link

github-actions bot commented Mar 9, 2022

Size Change: 0 B

Total Size: 791 kB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 49.9 kB
website/build/assets/css/styles.********.css 105 kB
website/build/assets/js/main.********.js 597 kB
website/build/index.html 38.4 kB

compressed-size-action

@slorber
Copy link
Collaborator

slorber commented Mar 9, 2022

#6109 ??? 🤪

@Josh-Cena
Copy link
Collaborator Author

Oh, oops, updated 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants