Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme-algolia): declare content-docs as dependency #6888

Merged
merged 1 commit into from
Mar 10, 2022

Conversation

Josh-Cena
Copy link
Collaborator

Motivation

This throws an error in pnp:

Module not found: Error: Can't resolve '@docusaurus/plugin-content-docs/client' in './.yarn/__virtual__/@docusaurus-theme-search-algolia-virtual-8b78fceaa5/0/cache/@docusaurus-theme-search-algolia-npm-2.0.0-beta.17-609067fadc-8a603d743a.zip/node_modules/@docusaurus/theme-search-algolia/lib/theme/SearchPage'

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Sadly our E2E test doesn't cover the search function

@Josh-Cena Josh-Cena added the pr: bug fix This PR fixes a bug in a past release. label Mar 10, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 10, 2022
@netlify
Copy link

netlify bot commented Mar 10, 2022

✔️ [V2]

🔨 Explore the source changes: 4703c29

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/622966680317dd000a4aaebe

😎 Browse the preview: https://deploy-preview-6888--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 68
🟢 Accessibility 100
🟢 Best practices 92
🟢 SEO 100
🟢 PWA 90

Lighthouse ran on https://deploy-preview-6888--docusaurus-2.netlify.app/

@github-actions
Copy link

Size Change: 0 B

Total Size: 791 kB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 49.9 kB
website/build/assets/css/styles.********.css 105 kB
website/build/assets/js/main.********.js 597 kB
website/build/index.html 38.7 kB

compressed-size-action

@Josh-Cena
Copy link
Collaborator Author

The error doesn't seem related—can be reproduced on master dating a few commits back as well. (Re-ran the actions of commits that used to pass.) To be debugged later.

@Josh-Cena Josh-Cena merged commit e842b40 into main Mar 10, 2022
@Josh-Cena Josh-Cena deleted the jc/fix-algolia branch March 10, 2022 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants