Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: do not print prototype in jest snapshot #6908

Merged
merged 1 commit into from
Mar 13, 2022
Merged

Conversation

Josh-Cena
Copy link
Collaborator

Motivation

This should help us when copying snapshots into code. In addition, I've made the window.location properly set up.

Have you read the Contributing Guidelines on pull requests?

Yes

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 13, 2022
@netlify
Copy link

netlify bot commented Mar 13, 2022

✔️ [V2]

🔨 Explore the source changes: 548d912

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/622dd17abdc865000835ecf2

😎 Browse the preview: https://deploy-preview-6908--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 52
🟢 Accessibility 100
🟢 Best practices 92
🟢 SEO 100
🟢 PWA 90

Lighthouse ran on https://deploy-preview-6908--docusaurus-2.netlify.app/

@github-actions
Copy link

Size Change: 0 B

Total Size: 792 kB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 49.9 kB
website/build/assets/css/styles.********.css 105 kB
website/build/assets/js/main.********.js 599 kB
website/build/index.html 38.7 kB

compressed-size-action

@Josh-Cena Josh-Cena merged commit 8c1e518 into main Mar 13, 2022
@Josh-Cena Josh-Cena deleted the jc/configure-jest branch March 13, 2022 11:34
@slorber
Copy link
Collaborator

slorber commented Mar 16, 2022

❤️ I wish I knew this option before thanks 👍

@Josh-Cena
Copy link
Collaborator Author

Haha, I think Orta implemented this option 😄 And everyone was like "Oh finally"

@slorber slorber added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants