refactor(core): move browserContext and docusaurusContext out of client exports #6955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Josh-Cena
added
the
pr: maintenance
|
✅ [V2] 🔨 Explore the source changes: d12eb17 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/623935c8444423000885a484 😎 Browse the preview: https://deploy-preview-6955--docusaurus-2.netlify.app |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-6955--docusaurus-2.netlify.app/ |
|
Size Change: 0 B Total Size: 805 kB ℹ️ View Unchanged
|
|
👍 wanted to do this follow-up refactor note that exposing docusaurus context provider might still be useful in the future for some theme authors that want to write tests, not sure they should use the same import as we do 😅 |
We would provide a unified testing interface. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
routeContextis architectured this way. I think it's cleaner than putting everything in exports, since these contexts aren't public APIs anyways.Have you read the Contributing Guidelines on pull requests?
Yes