chore: prevent importing theme components with relative paths #7674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slorber
added
the
pr: maintenance
slorber
commented
Jun 24, 2022
|
|
||
| .docusaurus-mt-lg { | ||
| /* Docusaurus-specific utility class */ | ||
| :global(.docusaurus-mt-lg) { |
There was a problem hiding this comment.
not really liking this solitary utility class 🤪 maybe we should just duplicate the rule everywhere 🤷♂️
| @@ -16,7 +16,7 @@ import { | |||
| import BlogLayout from '@theme/BlogLayout'; | |||
| import TagsListByLetter from '@theme/TagsListByLetter'; | |||
| import type {Props} from '@theme/BlogTagsListPage'; | |||
| import SearchMetadata from '../SearchMetadata'; | |||
There was a problem hiding this comment.
now catched with error
/Users/sebastienlorber/Desktop/projects/docusaurus/packages/docusaurus-theme-classic/src/theme/BlogTagsListPage/index.tsx
19:1 error '../SearchMetadata' import is restricted from being used by a pattern no-restricted-imports
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site settings. |
⚡️ Lighthouse report for the deploy preview of this PR
|
Josh-Cena
changed the title
|
Size Change: +52 B (0%) Total Size: 802 kB
ℹ️ View Unchanged
|
Josh-Cena
approved these changes
Jun 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-flight checklist
Motivation
ESLint should detect when using relative component imports between theme components
Also, we want to ensure consistent naming/usage of CSS module files
Test Plan
CI
Test links
Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/
Related issues/PRs