feat(theme): add queryString option to localeDropdown #8915
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-flight checklist
Motivation
This PR adds a
queryString
option to thelocaleDropdown
considering @slorber's review for #5890Test Plan
@slorber mentioned we should dogfood it but I wasn't sure how do it. I can think of two ways for dogfooding it:
queryString
option and uses Netlify Edge Functions to set a cookie to remember a user's preference.queryString
is properly appended to the URL.I manually tested the following cases:
undefined
.I'm happy to write tests for those cases (and additional ones I didn't think of) but I'll need some pointers on how to get started.
Test links
Deploy preview: https://deploy-preview-8915--docusaurus-2.netlify.app/
Related issues/PRs
#5890
#5839 (reply in thread)