-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mdx): add siteConfig.markdown.format to configure the default content parser (MDX / CommonMark) #9097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site settings. |
⚡️ Lighthouse report for the deploy preview of this PR
|
Size Change: +42 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
slorber
changed the title
feat(mdx): Add markdown.format siteConfig
feat(mdx): Add siteConfig.markdown.format
Jun 23, 2023
slorber
changed the title
feat(mdx): Add siteConfig.markdown.format
feat(mdx): Add siteConfig.markdown.format to configure the default content parser (MDX / CommonMark)
Jun 23, 2023
slorber
changed the title
feat(mdx): Add siteConfig.markdown.format to configure the default content parser (MDX / CommonMark)
feat(mdx): add siteConfig.markdown.format to configure the default content parser (MDX / CommonMark)
Jun 23, 2023
This was referenced Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Add a new
siteConfig.markdown.format
option.mdx
by default but allow opt-in for CommonMarkfrontMatter.mdx.format
wins oversiteConfig.markdown.format
Site config API:
This gives global control over the default parsing format used by MDX:
https://mdxjs.com/packages/mdx/#optionsformat
Possible values:
mdx
(default): parse all Markdown files as MDX (JSX)md
: parse all Markdown files as CommonMark (no JSX)detect
: parse Markdown files as MDX or CommonMark according to file extension (.mdx
vs.md
)Note: all 3 values are also possible to use as front matter like
format: md
, and front matter takes precedence over the site global markdown format setting.In Docusaurus v3 the default setting is
mdx
because historically Docusaurus v2 used to parse everything as MDX: let's keep this behavior for now to make the upgrade easier.In Docusaurus v4 we will likely switch to
detect
as a breaking chance, making it easier for CommonMark sites adopt Docusaurus without having to even know about this setting.Test Plan
Unit tests + dogfood + preview
Test links
Our website uses
format: 'detect'
, as a way to dogfood the CommonMark support: