Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade dependencies (non-major) #9148

Merged
merged 2 commits into from
Jul 16, 2023
Merged

chore: upgrade dependencies (non-major) #9148

merged 2 commits into from
Jul 16, 2023

Conversation

Josh-Cena
Copy link
Collaborator

This PR contains all the minor dependency version bumps. It should have no user effects because they will be included by re-locking anyway.

@Josh-Cena Josh-Cena added the pr: dependencies Pull requests that update a dependency file label Jul 16, 2023
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jul 16, 2023
@netlify
Copy link

netlify bot commented Jul 16, 2023

[V2]

Name Link
🔨 Latest commit bc98ad1
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/64b405f4f84c53000892f95c
😎 Deploy Preview https://deploy-preview-9148--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

github-actions bot commented Jul 16, 2023

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟢 95 🟢 97 🟢 92 🟢 100 🟠 89 Report
/docs/installation 🟠 76 🟢 100 🟢 92 🟢 100 🟠 89 Report

@github-actions
Copy link

github-actions bot commented Jul 16, 2023

Size Change: +99 B (0%)

Total Size: 1.1 MB

Filename Size Change
website/build/assets/js/main.********.js 828 kB +99 B (0%)
ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 117 kB
website/build/assets/css/styles.********.css 113 kB
website/build/index.html 41 kB

compressed-size-action

@Josh-Cena
Copy link
Collaborator Author

@shortcuts (Sorry for the ping on a Sunday!) This looks like another Algolia type bug:

Error: ../node_modules/@algolia/autocomplete-plugin-algolia-insights/dist/esm/types/InsightsClient.d.ts(1,75): error TS2307: Cannot find module 'search-insights' or its corresponding type declarations.

@shortcuts
Copy link
Contributor

@shortcuts (Sorry for the ping on a Sunday!) This looks like another Algolia type bug:

Error: ../node_modules/@algolia/autocomplete-plugin-algolia-insights/dist/esm/types/InsightsClient.d.ts(1,75): error TS2307: Cannot find module 'search-insights' or its corresponding type declarations.

Hey! Yes indeed there's a new option to add event tracking. I thought we shipped the peer dependency but it looks like not, (cc @shaneafsar) in the meantime you can maybe manually add it or remove the DocSearch bump so that it doesn't block you

@Josh-Cena
Copy link
Collaborator Author

The dependency review is due to outdated Lerna. I'll try to fix it later. Thank you @shortcuts! Hopefully it gets fixed soon.

@Josh-Cena Josh-Cena merged commit ff22728 into main Jul 16, 2023
@Josh-Cena Josh-Cena deleted the upgrade-deps branch July 16, 2023 15:44
@@ -33,21 +33,21 @@
"copy:watch": "node ../../admin/scripts/copyUntypedFiles.js --watch"
},
"dependencies": {
"@docsearch/react": "^3.3.3",
"@docsearch/react": "~3.3.3",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this downgrade intentional @Josh-Cena ? Went from 3.5.1 to 3.3.5 but don't see any reasoning in the PR

Copy link
Collaborator

@slorber slorber Sep 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it was intentional according to conversations above yes.

@shortcuts (Sorry for the ping on a Sunday!) This looks like another Algolia type bug:
Error: ../node_modules/@algolia/autocomplete-plugin-algolia-insights/dist/esm/types/InsightsClient.d.ts(1,75): error TS2307: Cannot find module 'search-insights' or its corresponding type declarations.

Hey! Yes indeed there's a new option to add event tracking. I thought we shipped the peer dependency but it looks like not, (cc @shaneafsar) in the meantime you can maybe manually add it or remove the DocSearch bump so that it doesn't block you

But apparently we can now upgrade safely (algolia/docsearch#2007) so I'll revert it

Edit: PR #9320

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants