-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade dependencies (non-major) #9148
Conversation
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
Size Change: +99 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
@shortcuts (Sorry for the ping on a Sunday!) This looks like another Algolia type bug: Error: ../node_modules/@algolia/autocomplete-plugin-algolia-insights/dist/esm/types/InsightsClient.d.ts(1,75): error TS2307: Cannot find module 'search-insights' or its corresponding type declarations. |
Hey! Yes indeed there's a new option to add event tracking. I thought we shipped the peer dependency but it looks like not, (cc @shaneafsar) in the meantime you can maybe manually add it or remove the DocSearch bump so that it doesn't block you |
The dependency review is due to outdated Lerna. I'll try to fix it later. Thank you @shortcuts! Hopefully it gets fixed soon. |
@@ -33,21 +33,21 @@ | |||
"copy:watch": "node ../../admin/scripts/copyUntypedFiles.js --watch" | |||
}, | |||
"dependencies": { | |||
"@docsearch/react": "^3.3.3", | |||
"@docsearch/react": "~3.3.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this downgrade intentional @Josh-Cena ? Went from 3.5.1 to 3.3.5 but don't see any reasoning in the PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it was intentional according to conversations above yes.
@shortcuts (Sorry for the ping on a Sunday!) This looks like another Algolia type bug:
Error: ../node_modules/@algolia/autocomplete-plugin-algolia-insights/dist/esm/types/InsightsClient.d.ts(1,75): error TS2307: Cannot find module 'search-insights' or its corresponding type declarations.Hey! Yes indeed there's a new option to add event tracking. I thought we shipped the peer dependency but it looks like not, (cc @shaneafsar) in the meantime you can maybe manually add it or remove the DocSearch bump so that it doesn't block you
But apparently we can now upgrade safely (algolia/docsearch#2007) so I'll revert it
Edit: PR #9320
This PR contains all the minor dependency version bumps. It should have no user effects because they will be included by re-locking anyway.