Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mdx-loader): prevent Open Graph images from being inserted as base64 #9369

Merged
merged 3 commits into from
Oct 5, 2023

Conversation

Zwyx
Copy link
Contributor

@Zwyx Zwyx commented Oct 4, 2023

Pre-flight checklist

Motivation

This prevents og:image from being inserted directly into the page as base64 data, which prevents them from being visible on Twitter, Slack, Signal, etc. More details at #9345.

Test Plan

Simply build the main website and notice the new build/assets/assets folder.

Test links

Deploy preview: https://deploy-preview-9369--docusaurus-2.netlify.app/

Related issues/PRs

it uses `file-loader` only, which will be used to prevent pages' thumbnails from being inserted into the page as base64 data
to prevent pages' thumbnails from being inserted into the page as base64 data
@netlify
Copy link

netlify bot commented Oct 4, 2023

[V2]

Name Link
🔨 Latest commit a952f4c
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/651e9656a09d8700086efd52
😎 Deploy Preview https://deploy-preview-9369--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

github-actions bot commented Oct 4, 2023

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 76 🟢 97 🟢 92 🟢 100 🟠 89 Report
/docs/installation 🟠 80 🟢 98 🟢 92 🟢 100 🟠 89 Report

@slorber slorber added the Argos Add this label to run UI visual regression tests. See argos.yml GH action. label Oct 5, 2023
@slorber slorber marked this pull request as ready for review October 5, 2023 10:56
@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Oct 5, 2023
@slorber
Copy link
Collaborator

slorber commented Oct 5, 2023

LGTM thanks 👍

For now I reverted to output images where they were previously: build/assets/images

We only support asset images for now and the way it's implemented is quite hacky. We'll improve later and see if we need to support something else than assets

@argos-ci
Copy link

argos-ci bot commented Oct 5, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 🧿 Changes detected (Review) 2 changes Oct 5, 2023, 11:12 AM

@slorber slorber merged commit e17784e into facebook:main Oct 5, 2023
29 of 31 checks passed
This was referenced Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Argos Add this label to run UI visual regression tests. See argos.yml GH action. CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Open Graph images can be inserted as base64, preventing social previews
3 participants