-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(mdx-loader): prevent Open Graph images from being inserted as base64 #9369
Conversation
it uses `file-loader` only, which will be used to prevent pages' thumbnails from being inserted into the page as base64 data
to prevent pages' thumbnails from being inserted into the page as base64 data
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
LGTM thanks 👍 For now I reverted to output images where they were previously: We only support asset images for now and the way it's implemented is quite hacky. We'll improve later and see if we need to support something else than assets |
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Pre-flight checklist
build/assets/assets
folder:Motivation
This prevents
og:image
from being inserted directly into the page as base64 data, which prevents them from being visible on Twitter, Slack, Signal, etc. More details at #9345.Test Plan
Simply build the main website and notice the new
build/assets/assets
folder.Test links
Deploy preview: https://deploy-preview-9369--docusaurus-2.netlify.app/
Related issues/PRs