Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade clsx to 2.0.0 #9464

Merged
merged 4 commits into from
Nov 21, 2023
Merged

chore: Upgrade clsx to 2.0.0 #9464

merged 4 commits into from
Nov 21, 2023

Conversation

harryzcy
Copy link
Contributor

@harryzcy harryzcy commented Oct 28, 2023

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Upgrading clsx to 2.0.0 doesn't seems to effect anything.
According to their release note, the breaking change is "Add "exports" map for native ESM support", which shouldn't effect docusaurus.

Test Plan

Test links

clsx v2.0.0 release note: https://github.com/lukeed/clsx/releases/tag/v2.0.0

Deploy preview: https://deploy-preview-9464--docusaurus-2.netlify.app/

Related issues/PRs

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Oct 28, 2023
@netlify
Copy link

netlify bot commented Oct 28, 2023

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit c6883b8
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/653cc3b44bc3290008283aab
😎 Deploy Preview https://deploy-preview-9464--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Oct 28, 2023

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 941b056
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/655cee73266e2300086fe96b
😎 Deploy Preview https://deploy-preview-9464--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

github-actions bot commented Oct 28, 2023

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 67 🟢 98 🟢 100 🟢 100 🟠 89 Report
/docs/installation 🟠 87 🟢 98 🟢 100 🟢 100 🟠 89 Report
/docs/category/getting-started 🟠 75 🟢 100 🟢 100 🟢 90 🟠 89 Report
/blog 🟠 73 🟢 100 🟢 100 🟢 90 🟠 89 Report
/blog/preparing-your-site-for-docusaurus-v3 🟠 64 🟢 97 🟢 100 🟢 100 🟠 89 Report
/blog/tags/release 🟠 74 🟢 100 🟢 100 🟠 80 🟠 89 Report
/blog/tags 🟠 77 🟢 100 🟢 100 🟢 90 🟠 89 Report

@slorber slorber added the Argos Add this label to run UI visual regression tests. See argos.yml GH action. label Oct 31, 2023
Copy link

argos-ci bot commented Oct 31, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 🧿 Changes detected (Review) 2 changes Nov 30, 2023, 6:56 PM

@harryzcy
Copy link
Contributor Author

@slorber Hi, is there any updates to this?

Copy link
Collaborator

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember I had problems before with upgrading, but since it builds fine, I guess it is fine :)

@Josh-Cena Josh-Cena added the pr: dependencies Pull requests that update a dependency file label Nov 13, 2023
@slorber slorber added the to backport This PR is planned to be backported to a stable version of Docusaurus label Nov 21, 2023
@slorber
Copy link
Collaborator

slorber commented Nov 21, 2023

LGTM thanks 👍

I guess it's fine to not consider this as a breaking change considering the impact should be very minimal and usage is mostly internal

@slorber slorber merged commit 2c0bf8a into facebook:main Nov 21, 2023
31 of 32 checks passed
@slorber
Copy link
Collaborator

slorber commented Nov 21, 2023

Missed it but an unfortunate result of this upgrade is that we now have twice the lib in our client bundle. Wondering if we'll backport this? 🤔

CleanShot 2023-11-21 at 19 37 08@2x

@carloskelly13 any plan to upgrade clsx in prism-react-renderer?

@Josh-Cena
Copy link
Collaborator

clsx is extremely small so not a huge deal. Upgrading would certainly be better, though.

@harryzcy
Copy link
Contributor Author

harryzcy commented Nov 21, 2023

Opened a PR: FormidableLabs/prism-react-renderer#232

@harryzcy harryzcy deleted the clsx-2.0.0 branch November 21, 2023 19:03
@carloskelly13
Copy link

@slorber Yeah, we'll get @harryzcy's PR merged in and we'll publish a build. Thanks for getting that in.

@carloskelly13
Copy link

@slorber Prism React Renderer 2.3.0 with clsx 2.0 is published. https://github.com/FormidableLabs/prism-react-renderer/releases/tag/prism-react-renderer%402.3.0

Thanks @harryzcy for the PR!

@slorber
Copy link
Collaborator

slorber commented Nov 21, 2023

thanks ❤️

slorber pushed a commit that referenced this pull request Nov 30, 2023
Co-authored-by: Joshua Chen <sidachen2003@gmail.com>
@slorber slorber added backported This PR has been backported to a stable version of Docusaurus and removed to backport This PR is planned to be backported to a stable version of Docusaurus labels Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Argos Add this label to run UI visual regression tests. See argos.yml GH action. backported This PR has been backported to a stable version of Docusaurus CLA Signed Signed Facebook CLA pr: dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants