Add support for A11y headers in Litho. #573
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI @astreet @adityasharat . Please review. Thanks |
astreet
requested changes
Jul 30, 2019
| @@ -1014,6 +1014,11 @@ public T importantForAccessibility(int importantForAccessibility) { | |||
| return getThis(); | |||
| } | |||
|
|
|||
| public T accessibilityHeading(boolean isHeading) { | |||
There was a problem hiding this comment.
Can you add javadocs here?
|
This looks good to me from an accessibility perspective. It's probably worth noting in the javadoc that this prop won't have any impact below API 19. |
|
Added javadoc. Please review. Thanks |
astreet
approved these changes
Jul 31, 2019
There was a problem hiding this comment.
@astreet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
anushreeag
added a commit
to anushreeag/litho
that referenced
this pull request
Aug 4, 2019
I submitted the PR for accessibility headers support : facebook#573 . Adding documentation now for the same.
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 27, 2019
Summary: <!-- Thanks for submitting a pull request! We appreciate you taking the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory. --> I submitted the PR for accessibility headers support : #573 . Adding documentation now for the same. <!-- Explain the **motivation** for making this change. What existing problem does the pull request solve? --> ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. This should just be a brief oneline we can mention in our release notes: https://github.com/facebook/litho/releases --> Pull Request resolved: #579 Test Plan: <!-- Demonstrate the code is solid. Example: The exact commands you ran and their output, output of the test runner and how you invoked it (you've added tests, right?), screenshots/videos if the pull request changes UI. --> Reviewed By: colriot Differential Revision: D18725611 Pulled By: muraziz fbshipit-source-id: 3373e6b99e20f83cde44852ea6e95e7d65f6a2d2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add support for Accessibility Headers in Litho.
This will help the users to choose to “Navigate by Headings” and ignore scrolling through each and every sub items under a heading. “Navigate based on Heading“ can be chosen from Local Context Menu with talkback on ( Gesture for local context menu - Swipe up then right).
ViewCompat and AccessibilityNodeInfoCompat have required API’s which can indicate that a view or corresponding accessibilityNode is an “Accessibility Heading” when talkback is enabled.
Changelog
Add support for Accessibility Headers in Litho.
Test Plan
Verified locally by switching talkback on and navigate by headers. It works fine and no crash found.