Update A11y doc with Accessibility heading support#579
Closed
anushreeag wants to merge 2 commits into
Closed
Conversation
I submitted the PR for accessibility headers support : facebook#573 . Adding documentation now for the same.
muraziz
suggested changes
Aug 6, 2019
muraziz
left a comment
muraziz
left a comment
Contributor
There was a problem hiding this comment.
@anushreeag thanks for sending this PR! Requesting changes mainly for styling
| .build(); | ||
| } | ||
| ``` | ||
| ## Accessibility Heading |
Contributor
There was a problem hiding this comment.
Can you add new line after this?
| ``` | ||
| ## Accessibility Heading | ||
| Heading is an accessibility property and will help the users to choose to “Navigate by Headings” and ignore scrolling through each and every sub items under a heading. “Navigate based on Heading“ can be selected from Local Context Menu when talkback is on. Talkback gesture for Local Context Menu is **Swipe up then right**. | ||
| Making any component an Accessibility Header is as simple as, |
Contributor
There was a problem hiding this comment.
New line before this line as it is new paragraph. Also please replace "," at the end with ":" to make it consistent with other usages above.
| Row.create(c) | ||
| .contentDescription("This is an accessibility heading") | ||
| .accessibilityHeading(true) | ||
| .build()) |
Contributor
There was a problem hiding this comment.
It should be .build(), the second parenthesis is excessive.
Fixing the review comments.
Contributor
Author
|
@muraziz , will you please review this ? |
1 similar comment
Contributor
Author
|
@muraziz , will you please review this ? |
facebook-github-bot
left a comment
facebook-github-bot
left a comment
Contributor
There was a problem hiding this comment.
@muraziz has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
muraziz
approved these changes
Nov 27, 2019
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I submitted the PR for accessibility headers support : #573 . Adding documentation now for the same.
Changelog
Test Plan