Skip to content

Commit 5a792db

Browse files
authored
track clicks on script links (#204)
1 parent 7edec7c commit 5a792db

File tree

2 files changed

+19
-2
lines changed

2 files changed

+19
-2
lines changed

front_end/core/host/RNPerfMetrics.ts

Lines changed: 18 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -302,7 +302,16 @@ class RNPerfMetrics {
302302
this.sendEvent({
303303
eventName: 'ManualBreakpointSetSucceeded',
304304
params: {
305-
bpSettingDuration
305+
bpSettingDuration,
306+
}
307+
});
308+
}
309+
310+
stackTraceFrameClicked(isLinkified: boolean): void {
311+
this.sendEvent({
312+
eventName: 'StackTraceFrameClicked',
313+
params: {
314+
isLinkified,
306315
}
307316
});
308317
}
@@ -498,6 +507,13 @@ export type StackTraceFrameUrlResolutionFailed = Readonly<{
498507
}>,
499508
}>;
500509

510+
export type StackTraceFrameClicked = Readonly<{
511+
eventName: 'StackTraceFrameClicked',
512+
params: Readonly<{
513+
isLinkified: boolean,
514+
}>,
515+
}>;
516+
501517
export type ManualBreakpointSetSucceeded = Readonly<{
502518
eventName: 'ManualBreakpointSetSucceeded',
503519
params: Readonly<{
@@ -511,6 +527,6 @@ export type ReactNativeChromeDevToolsEvent =
511527
DeveloperResourceLoadingFinishedEvent|FuseboxSetClientMetadataStartedEvent|FuseboxSetClientMetadataFinishedEvent|
512528
MemoryPanelActionStartedEvent|MemoryPanelActionFinishedEvent|PanelShownEvent|PanelClosedEvent|
513529
StackTraceSymbolicationSucceeded|StackTraceSymbolicationFailed|StackTraceFrameUrlResolutionSucceeded|
514-
StackTraceFrameUrlResolutionFailed|ManualBreakpointSetSucceeded;
530+
StackTraceFrameUrlResolutionFailed|ManualBreakpointSetSucceeded|StackTraceFrameClicked;
515531

516532
export type DecoratedReactNativeChromeDevToolsEvent = CommonEventFields&ReactNativeChromeDevToolsEvent;

front_end/ui/legacy/components/utils/Linkifier.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -665,6 +665,7 @@ export class Linkifier extends Common.ObjectWrapper.ObjectWrapper<EventTypes> im
665665
infoByAnchor.set(link, linkInfo);
666666
if (!preventClick) {
667667
link.addEventListener('click', event => {
668+
Host.rnPerfMetrics.stackTraceFrameClicked(linkInfo.liveLocation !== null);
668669
if (Linkifier.handleClick(event)) {
669670
event.consume(true);
670671
}

0 commit comments

Comments
 (0)