Skip to content

Conversation

hoxyq
Copy link

@hoxyq hoxyq commented Jun 11, 2025

Summary

Restores the legacy landing page that was removed from the upstream in ChromeDevTools@d0ba98e.

We should revisit this decision in the future when we would be able to show at least some live metrics.

Test plan

Before After
Screenshot 2025-06-11 at 16 20 03 Screenshot 2025-06-11 at 16 36 32
  • This change maintains backwards compatibility with previous Local Storage data (if modifying settings, experiments, or other persisted client state).

Upstreaming plan

  • This commit should be sent as a patch to the upstream devtools-frontend repo. I've reviewed the contribution guide.
  • This commit is React Native-specific and cannot be upstreamed.

@hoxyq hoxyq force-pushed the chore/restore-performance-landing-page branch from 6fc7520 to 473f14c Compare June 11, 2025 16:04
Copy link

@motiz88 motiz88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I wonder if there's a way to better preserve the history of the original landing page code. (Also, very silly nit: I don't thing this is a "chore" commit as it includes actual functional changes.)

@hoxyq
Copy link
Author

hoxyq commented Jun 11, 2025

I wonder if there's a way to better preserve the history of the original landing page code.

Probably? I am not sure, maybe partially reverting the original change and then modifying / renaming the file.

But since this file was removed, there should be no conflicts in the future, because this is RN-only. I am just expecting that whoever is going to stop by this file would open blame and read this PR, which has some context.

@hoxyq hoxyq changed the title chore: restore Performance landing page feat: restore Performance landing page Jun 11, 2025
@hoxyq hoxyq merged commit 68cfd0a into main Jun 11, 2025
5 checks passed
@hoxyq hoxyq deleted the chore/restore-performance-landing-page branch June 11, 2025 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants