Skip to content

Conversation

hoxyq
Copy link

@hoxyq hoxyq commented Aug 26, 2025

This reverts commit 7dcbddd.

Summary

I've discovered today that CDT has a native support for the panel query param, so we don't need a custom one.

this.tabbedLocation = ViewManager.instance().createTabbedLocation(
Host.InspectorFrontendHost.InspectorFrontendHostInstance.bringToFront.bind(
Host.InspectorFrontendHost.InspectorFrontendHostInstance),
'panel', true, true, Root.Runtime.Runtime.queryParam('panel'));

Test plan

  • This change maintains backwards compatibility with previous Local Storage data (if modifying settings, experiments, or other persisted client state).

Upstreaming plan

@hoxyq hoxyq requested a review from sbuggay August 26, 2025 17:46
@meta-cla meta-cla bot added the cla signed label Aug 26, 2025
@hoxyq hoxyq merged commit 273f026 into main Aug 27, 2025
5 checks passed
@hoxyq hoxyq deleted the revert-7dcbddd636137a9604d69a99cc69221216cd4be6 branch August 27, 2025 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants