Skip to content

Conversation

vzaidman
Copy link

@vzaidman vzaidman commented Sep 10, 2025

Summary

Track how long it takes to load all startup resources (bundle files, source maps, source files).

We consider all startup resources as loaded when the resources loading queue is empty, and no new resources were added to the queue for 3 whole seconds.

Test plan

See D82124701

  • This change maintains backwards compatibility with previous Local Storage data (if modifying settings, experiments, or other persisted client state).

Upstreaming plan

@meta-cla meta-cla bot added the cla signed label Sep 10, 2025
@vzaidman vzaidman force-pushed the track-all-resources-loaded-time branch 4 times, most recently from 3de3a54 to 6a792e3 Compare September 10, 2025 17:20
@vzaidman vzaidman force-pushed the track-all-resources-loaded-time branch from 6a792e3 to 7d4c777 Compare September 16, 2025 12:40
parsedURL, Host.UserMetrics.DeveloperResourceLoaded.FALLBACK_AFTER_FAILURE, result);

if (!this.#rndtStartupResourcesLoadedReported) {
// if no new resources were scheduled for loading for
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@huntie how do you find this comment, does it explain how this startup metric is calculated?

@vzaidman vzaidman force-pushed the track-all-resources-loaded-time branch from 7d4c777 to c464a88 Compare September 16, 2025 12:48
@vzaidman vzaidman requested a review from huntie September 16, 2025 12:48
@vzaidman vzaidman force-pushed the track-all-resources-loaded-time branch from c464a88 to d3aad37 Compare September 16, 2025 13:02
Copy link
Member

@huntie huntie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, approving with small nits!

@vzaidman vzaidman force-pushed the track-all-resources-loaded-time branch from d3aad37 to 07f9159 Compare September 18, 2025 10:37
@vzaidman vzaidman merged commit 538c309 into main Sep 18, 2025
5 checks passed
@vzaidman vzaidman deleted the track-all-resources-loaded-time branch September 18, 2025 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants