Skip to content
Permalink
Browse files

Disable OverlappingRendering for ReactTextView

Summary:
This diff disables OverlappingRendering for ReactTextView to avoid the exception:

```
java.lang.IllegalStateException: Unable to create layer for com.facebook.react.views.text.ReactTextView
```
during fade animations

OverlappingRendering enables an optimization during rendering of animations per component, disabling this might affect performance of animations inside TextView.

We will add a ReactFlag to experiment on how this affect other surfaces.

Reviewed By: blairvanderhoof

Differential Revision: D14027631

fbshipit-source-id: c1a84e7488c44582f7b7c78965aeb7bd27f82368
  • Loading branch information...
mdvacca authored and facebook-github-bot committed Feb 11, 2019
1 parent cdd6151 commit f83281e2ce2aece44b1207844d8a5149d5d2e78d
Showing with 5 additions and 0 deletions.
  1. +5 −0 ReactAndroid/src/main/java/com/facebook/react/views/text/ReactTextView.java
@@ -211,6 +211,11 @@ public void onFinishTemporaryDetach() {
}
}

@Override
public boolean hasOverlappingRendering() {
return false;
}

/* package */ void setGravityHorizontal(int gravityHorizontal) {
if (gravityHorizontal == 0) {
gravityHorizontal = mDefaultGravityHorizontal;

0 comments on commit f83281e

Please sign in to comment.
You can’t perform that action at this time.