-
Notifications
You must be signed in to change notification settings - Fork 24.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[iOS] Authorization header dropped when making HTTP requests that redirect #34627
Comments
|
Updated the react-native info output |
@hramos Please help |
I had tried building 0.70.0 as well to test it out but failed due to this harfbuzz/harfbuzzjs#34. |
It is a dup of #26311 but couldn't find its solution at that link. |
Have the same issue when building on a Mac device with M1 chip. If instead I build the app on a Mac with Intel chip everything works. |
Has anyone solved this issue in the m1 chip environment? |
Hello, @raduciobanu22 , not sure this is linked to m1. We faced the same issue on non m1 chip.
However, this does not cover for Here is a patch that you can apply that reads the header from the original request. diff --git a/node_modules/react-native/Libraries/Network/RCTHTTPRequestHandler.mm b/node_modules/react-native/Libraries/Network/RCTHTTPRequestHandler.mm
index 7b54592..66a2983 100644
--- a/node_modules/react-native/Libraries/Network/RCTHTTPRequestHandler.mm
+++ b/node_modules/react-native/Libraries/Network/RCTHTTPRequestHandler.mm
@@ -146,6 +146,14 @@ - (void)URLSession:(NSURLSession *)session
NSArray<NSHTTPCookie *> *cookies = [[NSHTTPCookieStorage sharedHTTPCookieStorage] cookiesForURL:request.URL];
nextRequest.allHTTPHeaderFields = [NSHTTPCookie requestHeaderFieldsWithCookies:cookies];
+
+ NSString *originalAuthorizationHeader = [task.originalRequest valueForHTTPHeaderField:@"Authorization"];
+
+ // forward the original Authorization if set
+ if (originalAuthorizationHeader) {
+ [nextRequest addValue:originalAuthorizationHeader forHTTPHeaderField:@"Authorization" ];
+ }
+
completionHandler(nextRequest);
} Please note that this is based on |
@fawad-khalil-retailo |
Thank you, it solved my problem. It's an unlikely reason and I can't explain it, but I also solved the problem by adding a "/" at the end of the URL. |
This worked for me. |
Description
I am requesting a URL of API service which responds with status code 307 (redirect) on success and a URL location in response Headers. This is protected API and needs Authorization header for it to be fulfilled successfully. The problem I am facing is that the Authorization header is not appended to the redirected URL, it is only appended to the original call, and therefore the redirected URL call fails with status 401. This works perfectly fine in Postman but is not working with Axios. This works fine in ReactJS web app and React Native mobile on Android OS, too. The problem is only on iOS platform. I have tried on a bare minimum RN app v.69.5 and v0.67.4 using
axios
andfetch
API and the results on iOS platform are the same, so it clearly is problem on iOS platform with React Native. There is one more strange behaviour, it works fine on iOS, too, if I connect the app with react-native-debugger and inspect the network calls. So the problem is only on iOS platform with chrome debugger disabled. I have tried usingmaxRedirects: 0
prop andbeforeRedirect
callback on axios but to no avail.Version
[0.67.4, 0.69.5]
Output of
npx react-native info
info Fetching system and libraries information...
System:
OS: macOS 12.4
CPU: (8) arm64 Apple M1
Memory: 313.20 MB / 16.00 GB
Shell: 5.8.1 - /bin/zsh
Binaries:
Node: 16.13.0 - ~/.nvm/versions/node/v16.13.0/bin/node
Yarn: 1.22.17 - ~/.nvm/versions/node/v16.13.0/bin/yarn
npm: 8.1.4 - ~/.nvm/versions/node/v16.13.0/bin/npm
Watchman: Not Found
Managers:
CocoaPods: 1.11.3 - /usr/local/bin/pod
SDKs:
iOS SDK:
Platforms: DriverKit 21.4, iOS 15.5, macOS 12.3, tvOS 15.4, watchOS 8.5
Android SDK: Not Found
IDEs:
Android Studio: 2020.3 AI-203.7717.56.2031.7784292
Xcode: 13.4.1/13F100 - /usr/bin/xcodebuild
Languages:
Java: 12.0.2 - /usr/bin/javac
npmPackages:
@react-native-community/cli: Not Found
react: 17.0.2 => 17.0.2
react-native: 0.67.4 => 0.67.4
react-native-macos: Not Found
npmGlobalPackages:
react-native: Not Found
Steps to reproduce
npx react-native init sampleapp --version 0.69.5
yarn add axios query-string
App.js
file:Snack, code example, screenshot, or link to a repository
https://snack.expo.dev/mhWvbpbX6
The text was updated successfully, but these errors were encountered: