Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add to PixelRation documentation information about iPhone SE and iPho… #20695

Closed
wants to merge 2 commits into from
Closed

Add to PixelRation documentation information about iPhone SE and iPho… #20695

wants to merge 2 commits into from

Conversation

janczer
Copy link
Contributor

@janczer janczer commented Aug 16, 2018

Release Notes:

[DOCS] [BUGFIX][PixelRatio.js] - Add information about iPhone SE and iPhone X

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@pull-bot
Copy link

Warnings
⚠️

📋 Test Plan - This PR appears to be missing a Test Plan.

Generated by 🚫 dangerJS

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 16, 2018
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@react-native-bot react-native-bot added Missing Test Plan This PR appears to be missing a test plan. ✅Release Notes labels Aug 16, 2018
@janczer janczer force-pushed the complite-doc-pixe-ration branch from 72e0065 to b57a1c6 Compare August 20, 2018 20:03
@facebook-github-bot facebook-github-bot added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Aug 20, 2018
facebook-github-bot
facebook-github-bot approved these changes Aug 20, 2018
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

This pull request was closed by @janczer in 24c0dc3.

Once this commit is added to a release, you will see the corresponding version tag below the description at 24c0dc3. If the commit has a single master tag, it is not yet part of a release.

@facebook facebook locked as resolved and limited conversation to collaborators Aug 20, 2018
@react-native-bot react-native-bot added the Merged This PR has been merged. label Aug 20, 2018
@hramos hramos removed Import Started This pull request has been imported. This does not imply the PR has been approved. labels Feb 6, 2019
t-nanava pushed a commit to microsoft/react-native-macos that referenced this pull request Jun 17, 2019
@janczer @facebook-github-bot
Add to PixelRation documentation information about iPhone SE and iPho… (
36a8211 
facebook#20695)

Summary:
Release Notes:
--------------

[DOCS] [BUGFIX][PixelRatio.js] - Add information about iPhone SE and iPhone X
Pull Request resolved: facebook#20695

Differential Revision: D9408433

Pulled By: hramos

fbshipit-source-id: 917390e30801ce353fd999b375c788bd38568a05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Missing Test Plan This PR appears to be missing a test plan.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@janczer @facebook-github-bot @pull-bot @react-native-bot @hramos