-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor Android Support Library in Buck #22096
Conversation
Generated by 🚫 dangerJS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Failed with |
I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mdvacca has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
closing in favor of #22962 |
Refactor Android Support Library in Buck
Rationale:
Many PRs involving Android Support Library were failed to import, even though Android CI is green (#20602, #19768, #20621). Also exports from FB to GitHub broke Android CI and fixed with 99632e1, 1edeaef.
After some investigation and help from FB developers, I found that BUCK target names for Android Support Library are different in GitHub and FB repos. Also there might be a software tool that translates/maps FB's Android Support Library dependencies into something like below in GitHub. But it's not working properly and results in cannot find symbol errors.
And this issue is blocking many improvements involving Android Support Library, and should be resolved as soon as possible.
Proposed solution:
Instead of translating/mapping Android Support Library target names in BUCK dependencies, which might break anytime, why not have same target names in both FB and GitHub, therefore have Android Support Library BUCK files to have different contents in FB and GitHub, due to FB internal requirements. This requires less mapping and less error prone.
Here are proposed steps to make it work.
Test Plan:
CI is green