-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: pod install with --project-directory #35754
Conversation
e2afe03
to
e93b7e9
Compare
Base commit: 4923a09 |
Base commit: 4923a09 |
PR build artifact for e93b7e9 is ready. |
PR build artifact for e93b7e9 is ready. |
@rshest has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
CC @dmytrorykun to double check. |
@dcangulo I have the exact same error with but when I go into the |
@arnaudambro This issue should be fixed in 0.72. For 0.71, you can do the following for a workaround. post_install do |installer|
react_native_post_install(
installer,
+ 'node_modules/react-native',
# Set `mac_catalyst_enabled` to `true` in order to apply patches
# necessary for Mac Catalyst builds
:mac_catalyst_enabled => false
)
__apply_Xcode_12_5_M1_post_install_workaround(installer)
end In your |
I'm using a monorepo and this worked perfectly, just needed to add the correct path. in my case: Thank! |
Doesn't this fix qualify for a 0.71.X cherry pick? Seems like it's worth including instead of waiting for another minor version release (0.72). |
@varemenos #36096 would fix it for 0.71.X |
Summary: The variable `version` is previously used but in facebook@2344860#diff-adcf572f001c2b710d14f409c14763f1a50b08369b3034548f1602685d21f67f, its usage have been removed the but the variable is kept. It also raises an error when using `bundle exec pod install --project-directory=ios` which works on `0.70.X` and below. ```txt No such file or directory @ rb_sysopen - ../node_modules/react-native/package.json /Users/davidangulo/Desktop/mobile/myapp/node_modules/react-native/scripts/react_native_pods.rb:212:in `read' /Users/davidangulo/Desktop/mobile/myapp/node_modules/react-native/scripts/react_native_pods.rb:212:in `react_native_post_install' ``` ## Changelog [IOS] [FIXED] - pod install with --project-directory Pull Request resolved: facebook#35754 Test Plan: `bundle exec pod install --project-directory=ios` should not raise an error. Reviewed By: christophpurrer Differential Revision: D42298517 Pulled By: rshest fbshipit-source-id: bef0b03312d2029188ae5437e3baf3ffce5cb73f
Summary: Exercise `pod install --project-directory=ios` when building the generated iOS project to make sure we don't regress in the future. See also #37992, #35754, #34215, https://github.com/facebook/react-native/issues/33909… ## Changelog: [INTERNAL] [ADDED] - Exercise `pod install --project-directory=ios` when testing the iOS template Pull Request resolved: #37996 Test Plan: CI should pass. Reviewed By: dmytrorykun Differential Revision: D46972815 Pulled By: cipolleschi fbshipit-source-id: 69617b09ac599eba3dde3ddddcf08db95bfc4da3
Summary
The variable
version
is previously used but in 2344860#diff-adcf572f001c2b710d14f409c14763f1a50b08369b3034548f1602685d21f67f, its usage have been removed the but the variable is kept.It also raises an error when using
bundle exec pod install --project-directory=ios
which works on0.70.X
and below.Changelog
[IOS] [FIXED] - pod install with --project-directory
Test Plan
bundle exec pod install --project-directory=ios
should not raise an error.