fix TouchableWithoutFeedback and TouchableOpacity dropping onPress in React 18 #42121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D52388699 |
|
This pull request was exported from Phabricator. Differential Revision: D52388699 |
sammy-SC
force-pushed
the
export-D52388699
branch
from
333dfb0
to
35b3bf3
Compare
sammy-SC
added a commit
to sammy-SC/react-native
that referenced
this pull request
Jan 2, 2024
… React 18 (facebook#42121) Summary: ## Changelog: [General][Fixed] - TouchableWithoutFeedback and TouchableOpacity dropping touches with React 18. TouchableWithoutFeedback and TouchableOpacity do not trigger onPress when used with React 18. This is because it resets its pressability configuration in `componentWillUnmount`. This is fine, we want to stop deliver events and restart all timers when component is unmounted. ``` componentWillUnmount(): void { this.state.pressability.reset(); } ``` But TouchableWithoutFeedback and TouchableOpacity were not restarting the pressability configuration when component was mounted again. It was restarting the configuration in `componentDidUpdate`, which is not called when component is unmounted and mounted again. Reviewed By: fkgozali Differential Revision: D52388699
|
This pull request was exported from Phabricator. Differential Revision: D52388699 |
… React 18 (facebook#42121) Summary: ## Changelog: [General][Fixed] - TouchableWithoutFeedback and TouchableOpacity dropping touches with React 18. TouchableWithoutFeedback and TouchableOpacity do not trigger onPress when used with React 18. This is because it resets its pressability configuration in `componentWillUnmount`. This is fine, we want to stop deliver events and restart all timers when component is unmounted. ``` componentWillUnmount(): void { this.state.pressability.reset(); } ``` But TouchableWithoutFeedback and TouchableOpacity were not restarting the pressability configuration when component was mounted again. It was restarting the configuration in `componentDidUpdate`, which is not called when component is unmounted and mounted again. Reviewed By: fkgozali Differential Revision: D52388699
sammy-SC
force-pushed
the
export-D52388699
branch
from
35b3bf3
to
17fd238
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52388699 |
|
This pull request has been merged in 5416634. |
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Jan 9, 2024
… React 18 (facebook#42121) Summary: Pull Request resolved: facebook#42121 ## Changelog: [General][Fixed] - TouchableWithoutFeedback and TouchableOpacity dropping touches with React 18. TouchableWithoutFeedback and TouchableOpacity do not trigger onPress when used with React 18. This is because it resets its pressability configuration in `componentWillUnmount`. This is fine, we want to stop deliver events and restart all timers when component is unmounted. ``` componentWillUnmount(): void { this.state.pressability.reset(); } ``` But TouchableWithoutFeedback and TouchableOpacity were not restarting the pressability configuration when component was mounted again. It was restarting the configuration in `componentDidUpdate`, which is not called when component is unmounted and mounted again. Reviewed By: fkgozali Differential Revision: D52388699 fbshipit-source-id: ef13194c6581c5d31d0f1cb465bfd0cf98d672ea
blakef
pushed a commit
that referenced
this pull request
Jan 25, 2024
… React 18 (#42121) Summary: Pull Request resolved: #42121 ## Changelog: [General][Fixed] - TouchableWithoutFeedback and TouchableOpacity dropping touches with React 18. TouchableWithoutFeedback and TouchableOpacity do not trigger onPress when used with React 18. This is because it resets its pressability configuration in `componentWillUnmount`. This is fine, we want to stop deliver events and restart all timers when component is unmounted. ``` componentWillUnmount(): void { this.state.pressability.reset(); } ``` But TouchableWithoutFeedback and TouchableOpacity were not restarting the pressability configuration when component was mounted again. It was restarting the configuration in `componentDidUpdate`, which is not called when component is unmounted and mounted again. Reviewed By: fkgozali Differential Revision: D52388699 fbshipit-source-id: ef13194c6581c5d31d0f1cb465bfd0cf98d672ea
This was referenced Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog:
[General][Fixed] - TouchableWithoutFeedback and TouchableOpacity dropping touches with React 18.
TouchableWithoutFeedback and TouchableOpacity do not trigger onPress when used with React 18. This is because it resets its pressability configuration in
componentWillUnmount. This is fine, we want to stop deliver events and restart all timers when component is unmounted.But TouchableWithoutFeedback and TouchableOpacity were not restarting the pressability configuration when component was mounted again. It was restarting the configuration in
componentDidUpdate, which is not called when component is unmounted and mounted again.Reviewed By: fkgozali
Differential Revision: D52388699