Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix TouchableWithoutFeedback and TouchableOpacity dropping onPress in React 18 #42121

Closed
wants to merge 1 commit into from

Commits on Jan 2, 2024

  1. fix TouchableWithoutFeedback and TouchableOpacity dropping onPress in…

    … React 18 (facebook#42121)
    
    Summary:
    
    ## Changelog: 
    [General][Fixed] - TouchableWithoutFeedback and TouchableOpacity dropping touches with React 18.
    
    
    TouchableWithoutFeedback and TouchableOpacity do not trigger onPress when used with React 18. This is because it resets its pressability configuration in `componentWillUnmount`. This is fine, we want to stop deliver events and restart all timers when component is unmounted.
    ```
    componentWillUnmount(): void {
        this.state.pressability.reset();
      }
    ```
    
    But TouchableWithoutFeedback and TouchableOpacity were not restarting the pressability configuration when component was mounted again. It was restarting the configuration in `componentDidUpdate`, which is not called when component is unmounted and mounted again.
    
    Reviewed By: fkgozali
    
    Differential Revision: D52388699
    sammy-SC authored and facebook-github-bot committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    17fd238 View commit details
    Browse the repository at this point in the history