Fix race condition between experimental_prefetchResources and surface stop #53861
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… stop Summary: Changelog: [Internal] The issue is a race condition in the React Native Fabric mounting system where `experimental_prefetchResources` is called on a `SurfaceMountingManager` after the surface has been stopped. 1.) `experimental_prefetchResources` is called 2.) Concurrently, `stopSurface()` *can be* called, which sets `mThemedReactContext = null` 3.) `experimental_prefetchResources` then tries to access `mThemedReactContext` via `Assertions.assertNotNull(mThemedReactContext)` 4.) Since `mThemedReactContext` is now `null`, the assertion fails and throws an AssertionError The fix involves adding a guard to check if the surface is stopped before accessing `mThemedReactContext` Follows existing patterns used by other methods in the same class https://github.com/facebook/react-native/blob/main/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/fabric/mounting/SurfaceMountingManager.java#L201-L213 Differential Revision: D82842572
meta-cla
bot
added
the
CLA Signed
facebook-github-bot
added
p: Facebook
|
@christophpurrer has exported this pull request. If you are a Meta employee, you can view the originating diff in D82842572. |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Sep 19, 2025
… stop (facebook#53861) Summary: Changelog: [Internal] The issue is a race condition in the React Native Fabric mounting system where `experimental_prefetchResources` is called on a `SurfaceMountingManager` after the surface has been stopped. 1.) `experimental_prefetchResources` is called 2.) Concurrently, `stopSurface()` *can be* called, which sets `mThemedReactContext = null` 3.) `experimental_prefetchResources` then tries to access `mThemedReactContext` via `Assertions.assertNotNull(mThemedReactContext)` 4.) Since `mThemedReactContext` is now `null`, the assertion fails and throws an AssertionError The fix involves adding a guard to check if the surface is stopped before accessing `mThemedReactContext` Follows existing patterns used by other methods in the same class https://github.com/facebook/react-native/blob/main/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/fabric/mounting/SurfaceMountingManager.java#L201-L213 Reviewed By: lenaic Differential Revision: D82842572
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Sep 20, 2025
… stop (facebook#53861) Summary: Changelog: [Internal] The issue is a race condition in the React Native Fabric mounting system where `experimental_prefetchResources` is called on a `SurfaceMountingManager` after the surface has been stopped. 1.) `experimental_prefetchResources` is called 2.) Concurrently, `stopSurface()` *can be* called, which sets `mThemedReactContext = null` 3.) `experimental_prefetchResources` then tries to access `mThemedReactContext` via `Assertions.assertNotNull(mThemedReactContext)` 4.) Since `mThemedReactContext` is now `null`, the assertion fails and throws an AssertionError The fix involves adding a guard to check if the surface is stopped before accessing `mThemedReactContext` Follows existing patterns used by other methods in the same class https://github.com/facebook/react-native/blob/main/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/fabric/mounting/SurfaceMountingManager.java#L201-L213 Reviewed By: lenaic Differential Revision: D82842572
|
This pull request has been merged in 362ed17. |
|
This pull request was successfully merged by @christophpurrer in 362ed17 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
The issue is a race condition in the React Native Fabric mounting system where
experimental_prefetchResourcesis called on aSurfaceMountingManagerafter the surface has been stopped.1.)
experimental_prefetchResourcesis called2.) Concurrently,
stopSurface()can be called, which setsmThemedReactContext = null3.)
experimental_prefetchResourcesthen tries to accessmThemedReactContextviaAssertions.assertNotNull(mThemedReactContext)4.) Since
mThemedReactContextis nownull, the assertion fails and throws an AssertionErrorThe fix involves adding a guard to check if the surface is stopped before accessing
mThemedReactContextFollows existing patterns used by other methods in the same class
https://github.com/facebook/react-native/blob/main/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/fabric/mounting/SurfaceMountingManager.java#L201-L213
Differential Revision: D82842572