[Threading] Increase the stack size for the React queue on older Android phones #7416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @mhorowitz and @astreet to be potential reviewers. |
ghost
added
GH Review: review-needed
CLA Signed
| @@ -44,10 +48,12 @@ public static Builder builder() { | |||
| } | |||
|
|
|||
| public static ReactQueueConfigurationSpec createDefault() { | |||
| MessageQueueThreadSpec spec = Build.VERSION.SDK_INT < 20 ? | |||
There was a problem hiding this comment.
Did you verify this is the correct SDK int?
There was a problem hiding this comment.
We were seeing the issue on KitKat (specifically API 19, don't have API 20) but not Marshmallow (API 21+). Changed this check to < 21 so that we cover all of KitKat.
|
This seems reasonable, thanks for gating to lower android versions |
ide
force-pushed
the
stack-size
branch
2 times, most recently
from
03a7c95
to
bc2dd2a
Compare
…oid phones Older Android devices don't have a large stack by default and with about 16 levels of views the app will crash. Modern Android devices are fine so we can continue to use the system defaults while using a 2MB stack on older Android devices. Test Plan: App that was crashing on older Android devices no longer crashes.
|
@ide updated the pull request. |
|
@facebook-github-bot shipit |
ghost
added
GH Review: accepted
Import Started
|
Thanks for importing. If you are an FB employee go to Phabricator to review. |
This was referenced Jun 8, 2016
zebulgar
pushed a commit
to nightingale/react-native
that referenced
this pull request
Jun 18, 2016
Summary: Older Android devices don't have a large stack by default and with about 16 levels of views the app will crash. Modern Android devices are fine so we can continue to use the system defaults while using a 2MB stack on older Android devices. Closes facebook#7416 Differential Revision: D3276805 Pulled By: astreet fbshipit-source-id: a7b31a1be62e13f333148ca0908eb01a11aa4562
samerce
pushed a commit
to iodine/react-native
that referenced
this pull request
Aug 23, 2016
Summary: Older Android devices don't have a large stack by default and with about 16 levels of views the app will crash. Modern Android devices are fine so we can continue to use the system defaults while using a 2MB stack on older Android devices. Closes facebook#7416 Differential Revision: D3276805 Pulled By: astreet fbshipit-source-id: a7b31a1be62e13f333148ca0908eb01a11aa4562
mpretty-cyro
pushed a commit
to HomePass/react-native
that referenced
this pull request
Aug 25, 2016
Summary: Older Android devices don't have a large stack by default and with about 16 levels of views the app will crash. Modern Android devices are fine so we can continue to use the system defaults while using a 2MB stack on older Android devices. Closes facebook#7416 Differential Revision: D3276805 Pulled By: astreet fbshipit-source-id: a7b31a1be62e13f333148ca0908eb01a11aa4562
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Older Android devices don't have a large stack by default and with about 16 levels of views the app will crash. Modern Android devices are fine so we can continue to use the system defaults while using a 2MB stack on older Android devices.
Test Plan: App that was crashing on older Android devices no longer crashes.
Fixes #5404