[Image] Warn for width/height props #789
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the user passes in a width or height prop to the Image component, warn them that they should set these values using style instead.
facebook-github-bot
added
the
CLA Signed
|
@vjeux - do you think this is worth adding? @blairvanderhoof - rebase needed here 😄 |
brentvatne
changed the title
|
Definitely worth it. Would be nice to add a if (DEV) { } around it so that it's not being run in prod |
|
@blairvanderhoof could you rebase and follow @vjeux's |
|
@blairvanderhoof updated the pull request. |
facebook-github-bot
added
GH Review: review-needed
and removed
GH Review: needs-revision
labels
|
Could you do this for Android too? We ask for parity in PRs to keep platforms in sync. |
|
@blairvanderhoof Any updates on this? |
|
Sorry, I need to find the time to do it, feel free to have someone take over. |
mganandraj
pushed a commit
to mganandraj/react-native
that referenced
this pull request
Oct 28, 2021
* Add nullability checks (facebook#704) * Update RCTCxxBridge.mm * add nullability checks * Check a nil URL to fix crashes connecting to socket (facebook#785) * Update RCTCxxBridge.mm * Update RCTCxxBridge.mm * nil check websocket URL * use RCTAssertParam Co-authored-by: Chris Hogan <chrishogan@Chriss-MacBook-Pro-2.local> * pod install Co-authored-by: Chris Hogan <chrishogan@Chriss-MacBook-Pro-2.local>
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 15, 2022
Summary: ## Summary Hermes added support for generators in 0.2.0, and JSC is ES6 feature complete since r202125. NOTE: This is a combined Metro + React Native commit. For React Native, the only change here is adding `babel/plugin-transform-regenerator` to `repo-config` ( = `devDependencies`), so the tests no longer implicitly consume it via Metro. Changelog: [Internal] X-link: facebook/metro#789 Reviewed By: rh389 Differential Revision: D34819044 Pulled By: motiz88 fbshipit-source-id: fe27b2c2af0281d5309d4c16f95762d4d4935eba
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user passes in a width or height prop to the Image component, warn them that they should set these values using style instead.