Remove unused www scheduler fork #13545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
👍 |
Details of bundled changes.Comparing: b473d5f...ea45942 schedule
Generated by 🚫 dangerJS |
jetoneza
pushed a commit
to jetoneza/react
that referenced
this pull request
Jan 23, 2019
Remove unused www scheduler fork
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fork was already being ignored on master because Scheduler is now a dependency of ReactDOM, and thus isn't being bundled with it. And in those cases our forking mechanism doesn't kick in.
It was also wrong because the exports in it don't match how those functions are named in www.
I'm deleting it. During the sync we'll need to rename our internal
customScheduleto justschedulefork in our wwwnode_modulesshims, and then tweak it to match theunstable_API names. We'll also need to tweak existingcustomSchedulecallsites.